Changeset 214820 in webkit

Timestamp:

Apr 3, 2017 11:00:06 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=167965

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-04-03
Reviewed by Jon Lee.

Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
can therefore be delivered later than expected by the test. This is already done for the first one,
do this for the second one also.

• platform/mac-wk2/TestExpectations:
• pointer-lock/mouse-event-delivery.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)
• pointer-lock/mouse-event-delivery.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-04-03  Jeremy Jones  <jeremyj@apple.com>
+
+        LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=167965
+
+        Reviewed by Jon Lee.
+
+        Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
+        can therefore be delivered later than expected by the test. This is already done for the first one,
+        do this for the second one also.
+
+        * platform/mac-wk2/TestExpectations:
+        * pointer-lock/mouse-event-delivery.html:
+
 2017-04-01  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -620 +620 @@
 webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/167965 pointer-lock/mouse-event-delivery.html [ Pass Failure ]
-
 webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
 

trunk/LayoutTests/pointer-lock/mouse-event-delivery.html

@@ -97 +97 @@
             debug("     With a lock in place send a wheel event.")
             targetdiv1.onwheel = eventNotExpected;
-            targetdiv2.onwheel = eventExpected;
+            targetdiv2.onwheel = eventExpectedThenNextStep;
             document.body.onwheel = eventExpected;
             if (window.eventSender) {
@@ -103 +103 @@
                 window.eventSender.mouseScrollBy(0,10);
             }
-            doNextStep();
         },
         function () {