Changeset 215038 in webkit

Timestamp:

Apr 6, 2017 8:23:53 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC][MIPS][DFG] Use x86 generic HasOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=170222

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-04-06
Reviewed by Yusuke Suzuki.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
use the X86 special version for HasOwnProperty on MIPS too.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
use the X86 special version for HasOwnProperty on MIPS too.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGFixupPhase.cpp (modified) (1 diff)
• dfg/DFGSpeculativeJIT32_64.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-04-06  Guillaume Emont  <guijemont@igalia.com>
+
+        [JSC][MIPS][DFG] Use x86 generic HasOwnProperty
+        https://bugs.webkit.org/show_bug.cgi?id=170222
+
+        Reviewed by Yusuke Suzuki.
+
+        * dfg/DFGFixupPhase.cpp:
+        (JSC::DFG::FixupPhase::fixupNode):
+        use the X86 special version for HasOwnProperty on MIPS too.
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::compile):
+        use the X86 special version for HasOwnProperty on MIPS too.
+
 2017-04-05  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp

@@ -1383 +1383 @@
         case HasOwnProperty: {
             fixEdge<ObjectUse>(node->child1());
-#if CPU(X86) && USE(JSVALUE32_64)
-            // We don't have enough registers to do anything interesting on x86.
+#if (CPU(X86) || CPU(MIPS)) && USE(JSVALUE32_64)
+            // We don't have enough registers to do anything interesting on x86 and mips.
             fixEdge<UntypedUse>(node->child2());
 #else

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

@@ -5078 +5078 @@
 
     case HasOwnProperty: {
-#if CPU(X86)
+#if CPU(X86) || CPU(MIPS)
         ASSERT(node->child2().useKind() == UntypedUse);
         SpeculateCellOperand object(this, node->child1());