Changeset 215166 in webkit

Timestamp:

Apr 9, 2017 2:48:06 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

generate-bindings-all.pl shouldn't use Perl threads
​https://bugs.webkit.org/show_bug.cgi?id=170106

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-09
Reviewed by Yusuke Suzuki.

The use of interpreter-based threads in Perl is officially
discouraged and not all Linux distributions and BSD compile Perl
with threads support. Use fork instead of threads to run
generate-bindings.pl in parallel.

• bindings/scripts/generate-bindings-all.pl:

(spawnGenerateBindingsIfNeeded): Added.
(executeCommand): Removed the workaround for Cygwin Perl threads.
(spawnCommand): Added.
(worker): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/generate-bindings-all.pl (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        generate-bindings-all.pl shouldn't use Perl threads
+        https://bugs.webkit.org/show_bug.cgi?id=170106
+
+        Reviewed by Yusuke Suzuki.
+
+        The use of interpreter-based threads in Perl is officially
+        discouraged and not all Linux distributions and BSD compile Perl
+        with threads support. Use fork instead of threads to run
+        generate-bindings.pl in parallel.
+
+        * bindings/scripts/generate-bindings-all.pl:
+        (spawnGenerateBindingsIfNeeded): Added.
+        (executeCommand): Removed the workaround for Cygwin Perl threads.
+        (spawnCommand): Added.
+        (worker): Deleted.
+
 2017-04-09  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/bindings/scripts/generate-bindings-all.pl

@@ -33 +33 @@
 use File::Find;
 use Getopt::Long;
-use threads;
-use threads::shared;
-use Thread::Queue;
 
 my $perl = $^X;
@@ -122 +119 @@
     needsUpdate(\@output, \@deps);
 }}, @idlFiles;
-my $queue = Thread::Queue->new(@idlFilesToUpdate);
-my $abort :shared = 0;
+
+my $abort = 0;
 my $totalCount = @idlFilesToUpdate;
-my $currentCount :shared = 0;
-
-my @threadPool = map { threads->create(\&worker) } (1 .. $numOfJobs);
-$_->join for @threadPool;
+my $currentCount = 0;
+
+spawnGenerateBindingsIfNeeded() for (1 .. $numOfJobs);
+while (waitpid(-1, 0) != -1) {
+    if ($?) {
+        $abort = 1;
+    }
+    spawnGenerateBindingsIfNeeded();
+}
 exit $abort;
 
@@ -158 +160 @@
 }
 
-sub worker {
-    while (my $file = $queue->dequeue_nb()) {
-        last if $abort;
-        eval {
-            $currentCount++;
-            my $basename = basename($file);
-            printProgress("[$currentCount/$totalCount] $basename");
-            executeCommand($perl, @args, $file) == 0 or die;
-        };
-        if ($@) {
-            $abort = 1;
-            die;
-        }
-    }
+sub spawnGenerateBindingsIfNeeded
+{
+    return if $abort;
+    return unless @idlFilesToUpdate;
+    my $file = shift @idlFilesToUpdate;
+    $currentCount++;
+    my $basename = basename($file);
+    printProgress("[$currentCount/$totalCount] $basename");
+    my $pid = spawnCommand($perl, @args, $file);
+    $abort = 1 unless defined $pid;
 }
 
@@ -197 +195 @@
 sub executeCommand
 {
-    if ($^O eq 'cygwin') {
-        # 'system' of Cygwin Perl doesn't seem thread-safe
-        my $pid = fork();
-        defined($pid) or die;
-        if ($pid == 0) {
-            exec(@_) or die;
-        }
-        waitpid($pid, 0);
-        return $?;
-    }
     if ($^O eq 'MSWin32') {
         return system(quoteCommand(@_));
     }
     return system(@_);
+}
+
+sub spawnCommand
+{
+    my $pid = fork();
+    if ($pid == 0) {
+        @_ = quoteCommand(@_) if ($^O eq 'MSWin32');
+        exec(@_);
+        die "Cannot exec";
+    }
+    return $pid;
 }