Changeset 215333 in webkit

Timestamp:

Apr 13, 2017 12:54:53 PM (7 years ago)

Author:

BJ Burg

Message:

Web Inspector: RTL: goto arrow is floated to the wrong side
​https://bugs.webkit.org/show_bug.cgi?id=170816

Reviewed by Matt Baker.

Float it to the other side if necessary.

• UserInterface/Views/Main.css:

(.go-to-link):
(body[dir=ltr] .go-to-link:not(.dont-float)):
(body[dir=rtl] .go-to-link:not(.dont-float)):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/Main.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-04-13  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: RTL: goto arrow is floated to the wrong side
+        https://bugs.webkit.org/show_bug.cgi?id=170816
+
+        Reviewed by Matt Baker.
+
+        Float it to the other side if necessary.
+
+        * UserInterface/Views/Main.css:
+        (.go-to-link):
+        (body[dir=ltr] .go-to-link:not(.dont-float)):
+        (body[dir=rtl] .go-to-link:not(.dont-float)):
+
 2017-04-12  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/Main.css

@@ -1 +1 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -271 +271 @@
 
 .go-to-link:not(.dont-float) {
-    float: right;
-    margin-left: 5px;
     max-width: 100%;
     text-overflow: ellipsis;
     overflow: hidden;
     white-space: nowrap;
+
+    --go-to-link-margin-start: 5px;
+}
+
+body[dir=ltr] .go-to-link:not(.dont-float) {
+    float: right;
+    margin-left: var(--go-to-link-margin-start);
+}
+
+body[dir=rtl] .go-to-link:not(.dont-float) {
+    float: left;
+    margin-right: var(--go-to-link-margin-start);
 }