Changeset 215735 in webkit

Timestamp:

Apr 25, 2017 9:10:03 AM (7 years ago)

Author:

clopez@igalia.com

Message:

[GTK] Improve an unit test for the JHBuild wrapper.
​https://bugs.webkit.org/show_bug.cgi?id=168036

Unreviewed follow-up patch after r215727

• Scripts/webkitpy/port/base_unittest.py:

(test_jhbuild_wrapper): Improve the unit test by ensuring the directory
wasn't there before calling MockFileSystem.maybe_make_directory(), and
also that it exists after calling it.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/base_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [GTK] Improve an unit test for the JHBuild wrapper.
+        https://bugs.webkit.org/show_bug.cgi?id=168036
+
+        Unreviewed follow-up patch after r215727
+
+        * Scripts/webkitpy/port/base_unittest.py:
+        (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
+        wasn't there before calling MockFileSystem.maybe_make_directory(), and
+        also that it exists after calling it.
+
 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/Scripts/webkitpy/port/base_unittest.py

@@ -399 +399 @@
         port = self.make_port(port_name='foo')
         port.port_name = 'foo'
+        jhbuild_path = port.path_from_webkit_base('WebKitBuild', 'Dependencies%s' % port.port_name.upper())
+        self.assertFalse(port._filesystem.isdir(jhbuild_path))
         self.assertFalse(port._should_use_jhbuild())
-        port._filesystem.maybe_make_directory(port.path_from_webkit_base('WebKitBuild', 'Dependencies%s' % port.port_name.upper()))
+        port._filesystem.maybe_make_directory(jhbuild_path)
+        self.assertTrue(port._filesystem.isdir(jhbuild_path))
         self.assertTrue(port._should_use_jhbuild())