Changeset 215792 in webkit

Timestamp:

Apr 25, 2017 10:18:09 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Unhandled enumeration values in IntlDateTimeFormat.cpp
​https://bugs.webkit.org/show_bug.cgi?id=171241

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2017-04-25
Reviewed by JF Bastien.

Added some missing cases of the UDateFormatField to partTypeString,
and made them conditional to the ICU version that added them.
This should remove the warnings that appear on platform builds using the
newer system ICU headers.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::partTypeString):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/IntlDateTimeFormat.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-04-25  Andy VanWagoner  <thetalecrafter@gmail.com>
+
+        Unhandled enumeration values in IntlDateTimeFormat.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=171241
+
+        Reviewed by JF Bastien.
+
+        Added some missing cases of the UDateFormatField to partTypeString,
+        and made them conditional to the ICU version that added them.
+        This should remove the warnings that appear on platform builds using the
+        newer system ICU headers.
+
+        * runtime/IntlDateTimeFormat.cpp:
+        (JSC::IntlDateTimeFormat::partTypeString):
+
 2017-04-25  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp

@@ -934 +934 @@
         return "weekday";
     case UDAT_AM_PM_FIELD:
+#if U_ICU_VERSION_MAJOR_NUM >= 57
+    case UDAT_AM_PM_MIDNIGHT_NOON_FIELD:
+    case UDAT_FLEXIBLE_DAY_PERIOD_FIELD:
+#endif
         return "dayPeriod";
     case UDAT_TIMEZONE_FIELD: