Changeset 215956 in webkit


Ignore:
Timestamp:
Apr 28, 2017 4:28:41 PM (7 years ago)
Author:
Chris Dumez
Message:

Stop using legacy ClientRect / ClientRectList in Internals
https://bugs.webkit.org/show_bug.cgi?id=171412

Reviewed by Simon Fraser.

Source/WebCore:

Stop using legacy ClientRect / ClientRectList in Internals amd use the
newer DOMRect instead.

  • dom/DOMRect.idl:
  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):
(WebCore::Page::touchEventRectsForEvent):
(WebCore::Page::passiveTouchEventListenerRects):

  • page/Page.h:
  • testing/Internals.cpp:

(WebCore::Internals::absoluteCaretBounds):
(WebCore::Internals::boundingBox):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::layoutViewportRect):
(WebCore::Internals::visualViewportRect):
(WebCore::Internals::touchEventRectsForEvent):
(WebCore::Internals::passiveTouchEventListenerRects):
(WebCore::Internals::nonFastScrollableRects):
(WebCore::Internals::selectionBounds):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Rebaseline existing tests as DOMRect has more properties than ClientRect.

  • fast/visual-viewport/nonzoomed-rects-expected.txt:
  • fast/visual-viewport/rtl-nonzoomed-rects-expected.txt:
  • fast/visual-viewport/rtl-zoomed-rects-expected.txt:
  • fast/visual-viewport/rubberbanding-viewport-rects-expected.txt:
  • fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt:
  • fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt:
  • fast/visual-viewport/zoomed-fixed-expected.txt:
  • fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
  • fast/visual-viewport/zoomed-rects-expected.txt:
  • inspector/dom/hideHighlight-expected.txt:
  • inspector/dom/highlightQuad-expected.txt:
  • inspector/dom/highlightRect-expected.txt:
Location:
trunk
Files:
22 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r215951 r215956  
     12017-04-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Stop using legacy ClientRect / ClientRectList in Internals
     4        https://bugs.webkit.org/show_bug.cgi?id=171412
     5
     6        Reviewed by Simon Fraser.
     7
     8        Rebaseline existing tests as DOMRect has more properties than ClientRect.
     9
     10        * fast/visual-viewport/nonzoomed-rects-expected.txt:
     11        * fast/visual-viewport/rtl-nonzoomed-rects-expected.txt:
     12        * fast/visual-viewport/rtl-zoomed-rects-expected.txt:
     13        * fast/visual-viewport/rubberbanding-viewport-rects-expected.txt:
     14        * fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt:
     15        * fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt:
     16        * fast/visual-viewport/zoomed-fixed-expected.txt:
     17        * fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
     18        * fast/visual-viewport/zoomed-rects-expected.txt:
     19        * inspector/dom/hideHighlight-expected.txt:
     20        * inspector/dom/highlightQuad-expected.txt:
     21        * inspector/dom/highlightRect-expected.txt:
     22
    1232017-04-28  Jeremy Jones  <jeremyj@apple.com>
    224
  • trunk/LayoutTests/fast/visual-viewport/nonzoomed-rects-expected.txt

    r208213 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
    88
    99Scrolled to 475, 525
    10 JSON.stringify(internals.layoutViewportRect()) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
    11 JSON.stringify(internals.visualViewportRect()) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
     10JSON.stringify(internals.layoutViewportRect()) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
     11JSON.stringify(internals.visualViewportRect()) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
    1212
    1313Scrolled to 100, 776
    14 JSON.stringify(internals.layoutViewportRect()) is {"top":776,"right":885,"bottom":1361,"left":100,"width":785,"height":585}
    15 JSON.stringify(internals.visualViewportRect()) is {"top":776,"right":885,"bottom":1361,"left":100,"width":785,"height":585}
     14JSON.stringify(internals.layoutViewportRect()) is {"x":100,"y":776,"width":785,"height":585,"top":776,"right":885,"bottom":1361,"left":100}
     15JSON.stringify(internals.visualViewportRect()) is {"x":100,"y":776,"width":785,"height":585,"top":776,"right":885,"bottom":1361,"left":100}
    1616
    1717Scrolled to 50, 300
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":300,"right":835,"bottom":885,"left":50,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":300,"right":835,"bottom":885,"left":50,"width":785,"height":585}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":50,"y":300,"width":785,"height":585,"top":300,"right":835,"bottom":885,"left":50}
     19JSON.stringify(internals.visualViewportRect()) is {"x":50,"y":300,"width":785,"height":585,"top":300,"right":835,"bottom":885,"left":50}
    2020PASS successfullyParsed is true
    2121
  • trunk/LayoutTests/fast/visual-viewport/rtl-nonzoomed-rects-expected.txt

    r208409 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
    88
    99Scrolled to -475, 525
    10 JSON.stringify(internals.layoutViewportRect()) is {"top":525,"right":310,"bottom":1110,"left":-475,"width":785,"height":585}
    11 JSON.stringify(internals.visualViewportRect()) is {"top":525,"right":310,"bottom":1110,"left":-475,"width":785,"height":585}
     10JSON.stringify(internals.layoutViewportRect()) is {"x":-475,"y":525,"width":785,"height":585,"top":525,"right":310,"bottom":1110,"left":-475}
     11JSON.stringify(internals.visualViewportRect()) is {"x":-475,"y":525,"width":785,"height":585,"top":525,"right":310,"bottom":1110,"left":-475}
    1212
    1313Scrolled to -100, 776
    14 JSON.stringify(internals.layoutViewportRect()) is {"top":776,"right":685,"bottom":1361,"left":-100,"width":785,"height":585}
    15 JSON.stringify(internals.visualViewportRect()) is {"top":776,"right":685,"bottom":1361,"left":-100,"width":785,"height":585}
     14JSON.stringify(internals.layoutViewportRect()) is {"x":-100,"y":776,"width":785,"height":585,"top":776,"right":685,"bottom":1361,"left":-100}
     15JSON.stringify(internals.visualViewportRect()) is {"x":-100,"y":776,"width":785,"height":585,"top":776,"right":685,"bottom":1361,"left":-100}
    1616
    1717Scrolled to -50, 300
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":300,"right":735,"bottom":885,"left":-50,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":300,"right":735,"bottom":885,"left":-50,"width":785,"height":585}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":-50,"y":300,"width":785,"height":585,"top":300,"right":735,"bottom":885,"left":-50}
     19JSON.stringify(internals.visualViewportRect()) is {"x":-50,"y":300,"width":785,"height":585,"top":300,"right":735,"bottom":885,"left":-50}
    2020PASS successfullyParsed is true
    2121
  • trunk/LayoutTests/fast/visual-viewport/rtl-zoomed-rects-expected.txt

    r208409 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":392.5,"bottom":292.5,"left":0,"width":392.5,"height":292.5}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":392.5,"height":292.5,"top":0,"right":392.5,"bottom":292.5,"left":0}
    88
    99Scrolled to -475, 525
    10 JSON.stringify(internals.layoutViewportRect()) is {"top":232.5,"right":310,"bottom":817.5,"left":-475,"width":785,"height":585}
    11 JSON.stringify(internals.visualViewportRect()) is {"top":525,"right":-82.5,"bottom":817.5,"left":-475,"width":392.5,"height":292.5}
     10JSON.stringify(internals.layoutViewportRect()) is {"x":-475,"y":232.5,"width":785,"height":585,"top":232.5,"right":310,"bottom":817.5,"left":-475}
     11JSON.stringify(internals.visualViewportRect()) is {"x":-475,"y":525,"width":392.5,"height":292.5,"top":525,"right":-82.5,"bottom":817.5,"left":-475}
    1212
    1313Scrolled to -100, 776
    14 JSON.stringify(internals.layoutViewportRect()) is {"top":483.5,"right":310,"bottom":1068.5,"left":-475,"width":785,"height":585}
    15 JSON.stringify(internals.visualViewportRect()) is {"top":776,"right":292.5,"bottom":1068.5,"left":-100,"width":392.5,"height":292.5}
     14JSON.stringify(internals.layoutViewportRect()) is {"x":-475,"y":483.5,"width":785,"height":585,"top":483.5,"right":310,"bottom":1068.5,"left":-475}
     15JSON.stringify(internals.visualViewportRect()) is {"x":-100,"y":776,"width":392.5,"height":292.5,"top":776,"right":292.5,"bottom":1068.5,"left":-100}
    1616
    1717Scrolled to -50, 300
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":300,"right":342.5,"bottom":885,"left":-442.5,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":300,"right":342.5,"bottom":592.5,"left":-50,"width":392.5,"height":292.5}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":-442.5,"y":300,"width":785,"height":585,"top":300,"right":342.5,"bottom":885,"left":-442.5}
     19JSON.stringify(internals.visualViewportRect()) is {"x":-50,"y":300,"width":392.5,"height":292.5,"top":300,"right":342.5,"bottom":592.5,"left":-50}
    2020PASS successfullyParsed is true
    2121
  • trunk/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt

    r212559 r215956  
    55
    66Scrolled to -123, -234
    7 JSON.stringify(layoutViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    8 JSON.stringify(visualViewport) is {"top":-234,"right":662,"bottom":351,"left":-123,"width":785,"height":585}
     7JSON.stringify(layoutViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     8JSON.stringify(visualViewport) is {"x":-123,"y":-234,"width":785,"height":585,"top":-234,"right":662,"bottom":351,"left":-123}
    99
    1010Scrolled to 475, 525
    11 JSON.stringify(layoutViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
    12 JSON.stringify(visualViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
     11JSON.stringify(layoutViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
     12JSON.stringify(visualViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
    1313
    1414Scrolled to 1800, 1850
    15 JSON.stringify(layoutViewport) is {"top":1695,"right":2008,"bottom":2280,"left":1223,"width":785,"height":585}
    16 JSON.stringify(visualViewport) is {"top":1850,"right":2585,"bottom":2435,"left":1800,"width":785,"height":585}
     15JSON.stringify(layoutViewport) is {"x":1223,"y":1695,"width":785,"height":585,"top":1695,"right":2008,"bottom":2280,"left":1223}
     16JSON.stringify(visualViewport) is {"x":1800,"y":1850,"width":785,"height":585,"top":1850,"right":2585,"bottom":2435,"left":1800}
    1717PASS successfullyParsed is true
    1818
  • trunk/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt

    r212559 r215956  
    55
    66Scrolled to -123, -234
    7 JSON.stringify(layoutViewport) is {"top":-234,"right":662,"bottom":351,"left":-123,"width":785,"height":585}
    8 JSON.stringify(visualViewport) is {"top":-234,"right":662,"bottom":351,"left":-123,"width":785,"height":585}
     7JSON.stringify(layoutViewport) is {"x":-123,"y":-234,"width":785,"height":585,"top":-234,"right":662,"bottom":351,"left":-123}
     8JSON.stringify(visualViewport) is {"x":-123,"y":-234,"width":785,"height":585,"top":-234,"right":662,"bottom":351,"left":-123}
    99
    1010Scrolled to 475, 525
    11 JSON.stringify(layoutViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
    12 JSON.stringify(visualViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
     11JSON.stringify(layoutViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
     12JSON.stringify(visualViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
    1313
    1414Scrolled to 1800, 1850
    15 JSON.stringify(layoutViewport) is {"top":1850,"right":2585,"bottom":2435,"left":1800,"width":785,"height":585}
    16 JSON.stringify(visualViewport) is {"top":1850,"right":2585,"bottom":2435,"left":1800,"width":785,"height":585}
     15JSON.stringify(layoutViewport) is {"x":1800,"y":1850,"width":785,"height":585,"top":1850,"right":2585,"bottom":2435,"left":1800}
     16JSON.stringify(visualViewport) is {"x":1800,"y":1850,"width":785,"height":585,"top":1850,"right":2585,"bottom":2435,"left":1800}
    1717PASS successfullyParsed is true
    1818
  • trunk/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt

    r211379 r215956  
    55
    66Scrolled to -123, -234
    7 JSON.stringify(layoutViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    8 JSON.stringify(visualViewport) is {"top":-234,"right":662,"bottom":299,"left":-123,"width":785,"height":533}
     7JSON.stringify(layoutViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     8JSON.stringify(visualViewport) is {"x":-123,"y":-234,"width":785,"height":533,"top":-234,"right":662,"bottom":299,"left":-123}
    99
    1010Scrolled to 475, 525
    11 JSON.stringify(layoutViewport) is {"top":473,"right":1260,"bottom":1058,"left":475,"width":785,"height":585}
    12 JSON.stringify(visualViewport) is {"top":473,"right":1260,"bottom":1058,"left":475,"width":785,"height":585}
     11JSON.stringify(layoutViewport) is {"x":475,"y":473,"width":785,"height":585,"top":473,"right":1260,"bottom":1058,"left":475}
     12JSON.stringify(visualViewport) is {"x":475,"y":473,"width":785,"height":585,"top":473,"right":1260,"bottom":1058,"left":475}
    1313
    1414Scrolled to 1800, 1700
    15 JSON.stringify(layoutViewport) is {"top":1648,"right":2008,"bottom":2233,"left":1223,"width":785,"height":585}
    16 JSON.stringify(visualViewport) is {"top":1648,"right":2585,"bottom":2233,"left":1800,"width":785,"height":585}
     15JSON.stringify(layoutViewport) is {"x":1223,"y":1648,"width":785,"height":585,"top":1648,"right":2008,"bottom":2233,"left":1223}
     16JSON.stringify(visualViewport) is {"x":1800,"y":1648,"width":785,"height":585,"top":1648,"right":2585,"bottom":2233,"left":1800}
    1717PASS successfullyParsed is true
    1818
  • trunk/LayoutTests/fast/visual-viewport/zoomed-fixed-expected.txt

    r215892 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":392.5,"bottom":292.5,"left":0,"width":392.5,"height":292.5}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":392.5,"height":292.5,"top":0,"right":392.5,"bottom":292.5,"left":0}
    88client rect of top:
    99JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":0,"y":0,"width":785,"height":100,"top":0,"right":785,"bottom":100,"left":0}
     
    1616
    1717Scrolled to 475, 525
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":232.5,"right":867.5,"bottom":817.5,"left":82.5,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":525,"right":867.5,"bottom":817.5,"left":475,"width":392.5,"height":292.5}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":232.5,"width":785,"height":585,"top":232.5,"right":867.5,"bottom":817.5,"left":82.5}
     19JSON.stringify(internals.visualViewportRect()) is {"x":475,"y":525,"width":392.5,"height":292.5,"top":525,"right":867.5,"bottom":817.5,"left":475}
    2020client rect of top:
    2121JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":-392.5,"y":-292.5,"width":785,"height":100,"top":-292.5,"right":392.5,"bottom":-192.5,"left":-392.5}
     
    2828
    2929Scrolled to 100, 776
    30 JSON.stringify(internals.layoutViewportRect()) is {"top":483.5,"right":867.5,"bottom":1068.5,"left":82.5,"width":785,"height":585}
    31 JSON.stringify(internals.visualViewportRect()) is {"top":776,"right":492.5,"bottom":1068.5,"left":100,"width":392.5,"height":292.5}
     30JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":483.5,"width":785,"height":585,"top":483.5,"right":867.5,"bottom":1068.5,"left":82.5}
     31JSON.stringify(internals.visualViewportRect()) is {"x":100,"y":776,"width":392.5,"height":292.5,"top":776,"right":492.5,"bottom":1068.5,"left":100}
    3232client rect of top:
    3333JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":-17.5,"y":-292.5,"width":785,"height":100,"top":-292.5,"right":767.5,"bottom":-192.5,"left":-17.5}
     
    4040
    4141Scrolled to 50, 300
    42 JSON.stringify(internals.layoutViewportRect()) is {"top":300,"right":835,"bottom":885,"left":50,"width":785,"height":585}
    43 JSON.stringify(internals.visualViewportRect()) is {"top":300,"right":442.5,"bottom":592.5,"left":50,"width":392.5,"height":292.5}
     42JSON.stringify(internals.layoutViewportRect()) is {"x":50,"y":300,"width":785,"height":585,"top":300,"right":835,"bottom":885,"left":50}
     43JSON.stringify(internals.visualViewportRect()) is {"x":50,"y":300,"width":392.5,"height":292.5,"top":300,"right":442.5,"bottom":592.5,"left":50}
    4444client rect of top:
    4545JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":0,"y":0,"width":785,"height":100,"top":0,"right":785,"bottom":100,"left":0}
  • trunk/LayoutTests/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt

    r215892 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":392.5,"bottom":271,"left":0,"width":392.5,"height":271}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":392.5,"height":271,"top":0,"right":392.5,"bottom":271,"left":0}
    88client rect of top:
    99JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":0,"y":0,"width":785,"height":100,"top":0,"right":785,"bottom":100,"left":0}
     
    1616
    1717Scrolled to 475, 525
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":211,"right":867.5,"bottom":796,"left":82.5,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":503.5,"right":867.5,"bottom":796,"left":475,"width":392.5,"height":292.5}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":211,"width":785,"height":585,"top":211,"right":867.5,"bottom":796,"left":82.5}
     19JSON.stringify(internals.visualViewportRect()) is {"x":475,"y":503.5,"width":392.5,"height":292.5,"top":503.5,"right":867.5,"bottom":796,"left":475}
    2020client rect of top:
    2121JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":-392.5,"y":-314,"width":785,"height":100,"top":-314,"right":392.5,"bottom":-214,"left":-392.5}
     
    2828
    2929Scrolled to 100, 776
    30 JSON.stringify(internals.layoutViewportRect()) is {"top":462,"right":867.5,"bottom":1047,"left":82.5,"width":785,"height":585}
    31 JSON.stringify(internals.visualViewportRect()) is {"top":754.5,"right":492.5,"bottom":1047,"left":100,"width":392.5,"height":292.5}
     30JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":462,"width":785,"height":585,"top":462,"right":867.5,"bottom":1047,"left":82.5}
     31JSON.stringify(internals.visualViewportRect()) is {"x":100,"y":754.5,"width":392.5,"height":292.5,"top":754.5,"right":492.5,"bottom":1047,"left":100}
    3232client rect of top:
    3333JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":-17.5,"y":-314,"width":785,"height":100,"top":-314,"right":767.5,"bottom":-214,"left":-17.5}
     
    4040
    4141Scrolled to 50, 300
    42 JSON.stringify(internals.layoutViewportRect()) is {"top":278.5,"right":835,"bottom":863.5,"left":50,"width":785,"height":585}
    43 JSON.stringify(internals.visualViewportRect()) is {"top":278.5,"right":442.5,"bottom":571,"left":50,"width":392.5,"height":292.5}
     42JSON.stringify(internals.layoutViewportRect()) is {"x":50,"y":278.5,"width":785,"height":585,"top":278.5,"right":835,"bottom":863.5,"left":50}
     43JSON.stringify(internals.visualViewportRect()) is {"x":50,"y":278.5,"width":392.5,"height":292.5,"top":278.5,"right":442.5,"bottom":571,"left":50}
    4444client rect of top:
    4545JSON.stringify(fixedElement.getBoundingClientRect()) is {"x":0,"y":-21.5,"width":785,"height":100,"top":-21.5,"right":785,"bottom":78.5,"left":0}
  • trunk/LayoutTests/fast/visual-viewport/zoomed-rects-expected.txt

    r208213 r215956  
    44
    55
    6 JSON.stringify(internals.layoutViewportRect()) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    7 JSON.stringify(internals.visualViewportRect()) is {"top":0,"right":392.5,"bottom":292.5,"left":0,"width":392.5,"height":292.5}
     6JSON.stringify(internals.layoutViewportRect()) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     7JSON.stringify(internals.visualViewportRect()) is {"x":0,"y":0,"width":392.5,"height":292.5,"top":0,"right":392.5,"bottom":292.5,"left":0}
    88
    99Scrolled to 475, 525
    10 JSON.stringify(internals.layoutViewportRect()) is {"top":232.5,"right":867.5,"bottom":817.5,"left":82.5,"width":785,"height":585}
    11 JSON.stringify(internals.visualViewportRect()) is {"top":525,"right":867.5,"bottom":817.5,"left":475,"width":392.5,"height":292.5}
     10JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":232.5,"width":785,"height":585,"top":232.5,"right":867.5,"bottom":817.5,"left":82.5}
     11JSON.stringify(internals.visualViewportRect()) is {"x":475,"y":525,"width":392.5,"height":292.5,"top":525,"right":867.5,"bottom":817.5,"left":475}
    1212
    1313Scrolled to 100, 776
    14 JSON.stringify(internals.layoutViewportRect()) is {"top":483.5,"right":867.5,"bottom":1068.5,"left":82.5,"width":785,"height":585}
    15 JSON.stringify(internals.visualViewportRect()) is {"top":776,"right":492.5,"bottom":1068.5,"left":100,"width":392.5,"height":292.5}
     14JSON.stringify(internals.layoutViewportRect()) is {"x":82.5,"y":483.5,"width":785,"height":585,"top":483.5,"right":867.5,"bottom":1068.5,"left":82.5}
     15JSON.stringify(internals.visualViewportRect()) is {"x":100,"y":776,"width":392.5,"height":292.5,"top":776,"right":492.5,"bottom":1068.5,"left":100}
    1616
    1717Scrolled to 50, 300
    18 JSON.stringify(internals.layoutViewportRect()) is {"top":300,"right":835,"bottom":885,"left":50,"width":785,"height":585}
    19 JSON.stringify(internals.visualViewportRect()) is {"top":300,"right":442.5,"bottom":592.5,"left":50,"width":392.5,"height":292.5}
     18JSON.stringify(internals.layoutViewportRect()) is {"x":50,"y":300,"width":785,"height":585,"top":300,"right":835,"bottom":885,"left":50}
     19JSON.stringify(internals.visualViewportRect()) is {"x":50,"y":300,"width":392.5,"height":292.5,"top":300,"right":442.5,"bottom":592.5,"left":50}
    2020PASS successfullyParsed is true
    2121
  • trunk/LayoutTests/inspector/dom/hideHighlight-expected.txt

    r189416 r215956  
    88-- Running test case: HighlightRect
    99PASS: Should be one highlight rect.
    10 Highlight Rect: {"top":0,"right":100,"bottom":100,"left":0,"width":100,"height":100}
     10Highlight Rect: {"x":0,"y":0,"width":100,"height":100,"top":0,"right":100,"bottom":100,"left":0}
    1111
    1212-- Running test case: HideHighlight
     
    1515-- Running test case: HighlightQuad
    1616PASS: Should be one highlight rect.
    17 Highlight Rect: {"top":100,"right":150,"bottom":200,"left":50,"width":100,"height":100}
     17Highlight Rect: {"x":50,"y":100,"width":100,"height":100,"top":100,"right":150,"bottom":200,"left":50}
    1818
    1919-- Running test case: HideHighlight
  • trunk/LayoutTests/inspector/dom/highlightQuad-expected.txt

    r189416 r215956  
    88-- Running test case: HighlightSmallRectWithQuad
    99PASS: Should be one highlight rect.
    10 Highlight Rect: {"top":0,"right":100,"bottom":100,"left":0,"width":100,"height":100}
     10Highlight Rect: {"x":0,"y":0,"width":100,"height":100,"top":0,"right":100,"bottom":100,"left":0}
    1111
    1212-- Running test case: HighlightSmallQuadViewportCoordinates
    1313PASS: Should be one highlight rect.
    14 Highlight Rect: {"top":100,"right":150,"bottom":200,"left":50,"width":100,"height":100}
     14Highlight Rect: {"x":50,"y":100,"width":100,"height":100,"top":100,"right":150,"bottom":200,"left":50}
    1515
    1616-- Running test case: HighlightSmallQuadPageCoordinates
    1717PASS: Should be one highlight rect.
    18 Highlight Rect: {"top":90,"right":140,"bottom":190,"left":40,"width":100,"height":100}
     18Highlight Rect: {"x":40,"y":90,"width":100,"height":100,"top":90,"right":140,"bottom":190,"left":40}
    1919
    2020-- Running test case: HighlightSmallUnspecifiedCoordinatesUsesViewportCoordinates
    2121PASS: Should be one highlight rect.
    22 Highlight Rect: {"top":100,"right":150,"bottom":200,"left":50,"width":100,"height":100}
     22Highlight Rect: {"x":50,"y":100,"width":100,"height":100,"top":100,"right":150,"bottom":200,"left":50}
    2323
    2424-- Running test case: HighlightLargeQuadViewportCoordinates
    2525PASS: Should be one highlight rect.
    26 Highlight Rect: {"top":0,"right":1000,"bottom":2000,"left":0,"width":1000,"height":2000}
     26Highlight Rect: {"x":0,"y":0,"width":1000,"height":2000,"top":0,"right":1000,"bottom":2000,"left":0}
    2727
    2828-- Running test case: HighlightLargeQuadPageCoordinates
    2929PASS: Should be one highlight rect.
    30 Highlight Rect: {"top":-10,"right":990,"bottom":1990,"left":-10,"width":1000,"height":2000}
     30Highlight Rect: {"x":-10,"y":-10,"width":1000,"height":2000,"top":-10,"right":990,"bottom":1990,"left":-10}
    3131
    3232-- Running test case: BadQuadShouldError
  • trunk/LayoutTests/inspector/dom/highlightRect-expected.txt

    r189416 r215956  
    88-- Running test case: HighlightSmallRectViewportCoordinates
    99PASS: Should be one highlight rect.
    10 Highlight Rect: {"top":0,"right":100,"bottom":200,"left":0,"width":100,"height":200}
     10Highlight Rect: {"x":0,"y":0,"width":100,"height":200,"top":0,"right":100,"bottom":200,"left":0}
    1111
    1212-- Running test case: HighlightSmallRectPageCoordinates
    1313PASS: Should be one highlight rect.
    14 Highlight Rect: {"top":-10,"right":90,"bottom":190,"left":-10,"width":100,"height":200}
     14Highlight Rect: {"x":-10,"y":-10,"width":100,"height":200,"top":-10,"right":90,"bottom":190,"left":-10}
    1515
    1616-- Running test case: HighlightSmallRectUnspecifiedCoordinatesUsesViewportCoordinates
    1717PASS: Should be one highlight rect.
    18 Highlight Rect: {"top":0,"right":100,"bottom":200,"left":0,"width":100,"height":200}
     18Highlight Rect: {"x":0,"y":0,"width":100,"height":200,"top":0,"right":100,"bottom":200,"left":0}
    1919
    2020-- Running test case: HighlightLargeRectViewportCoordinates
    2121PASS: Should be one highlight rect.
    22 Highlight Rect: {"top":0,"right":100000,"bottom":200000,"left":0,"width":100000,"height":200000}
     22Highlight Rect: {"x":0,"y":0,"width":100000,"height":200000,"top":0,"right":100000,"bottom":200000,"left":0}
    2323
    2424-- Running test case: HighlightLargeRectPageCoordinates
    2525PASS: Should be one highlight rect.
    26 Highlight Rect: {"top":-10,"right":99990,"bottom":199990,"left":-10,"width":100000,"height":200000}
     26Highlight Rect: {"x":-10,"y":-10,"width":100000,"height":200000,"top":-10,"right":99990,"bottom":199990,"left":-10}
    2727
    2828-- Running test case: HighlightEmptyRect
    2929PASS: Should be one highlight rect.
    30 Highlight Rect: {"top":0,"right":0,"bottom":0,"left":0,"width":0,"height":0}
     30Highlight Rect: {"x":0,"y":0,"width":0,"height":0,"top":0,"right":0,"bottom":0,"left":0}
    3131
  • trunk/LayoutTests/platform/mac-wk1/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt

    r212559 r215956  
    55
    66Scrolled to 0, 0
    7 JSON.stringify(layoutViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
    8 JSON.stringify(visualViewport) is {"top":0,"right":785,"bottom":585,"left":0,"width":785,"height":585}
     7JSON.stringify(layoutViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
     8JSON.stringify(visualViewport) is {"x":0,"y":0,"width":785,"height":585,"top":0,"right":785,"bottom":585,"left":0}
    99
    1010Scrolled to 475, 525
    11 JSON.stringify(layoutViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
    12 JSON.stringify(visualViewport) is {"top":525,"right":1260,"bottom":1110,"left":475,"width":785,"height":585}
     11JSON.stringify(layoutViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
     12JSON.stringify(visualViewport) is {"x":475,"y":525,"width":785,"height":585,"top":525,"right":1260,"bottom":1110,"left":475}
    1313
    1414Scrolled to 1223, 1713
    15 JSON.stringify(layoutViewport) is {"top":1713,"right":2008,"bottom":2298,"left":1223,"width":785,"height":585}
    16 JSON.stringify(visualViewport) is {"top":1713,"right":2008,"bottom":2298,"left":1223,"width":785,"height":585}
     15JSON.stringify(layoutViewport) is {"x":1223,"y":1713,"width":785,"height":585,"top":1713,"right":2008,"bottom":2298,"left":1223}
     16JSON.stringify(visualViewport) is {"x":1223,"y":1713,"width":785,"height":585,"top":1713,"right":2008,"bottom":2298,"left":1223}
    1717PASS successfullyParsed is true
    1818
  • trunk/Source/WebCore/ChangeLog

    r215955 r215956  
     12017-04-28  Chris Dumez  <cdumez@apple.com>
     2
     3        Stop using legacy ClientRect / ClientRectList in Internals
     4        https://bugs.webkit.org/show_bug.cgi?id=171412
     5
     6        Reviewed by Simon Fraser.
     7
     8        Stop using legacy ClientRect / ClientRectList in Internals amd use the
     9        newer DOMRect instead.
     10
     11        * dom/DOMRect.idl:
     12        * page/Page.cpp:
     13        (WebCore::Page::nonFastScrollableRects):
     14        (WebCore::Page::touchEventRectsForEvent):
     15        (WebCore::Page::passiveTouchEventListenerRects):
     16        * page/Page.h:
     17        * testing/Internals.cpp:
     18        (WebCore::Internals::absoluteCaretBounds):
     19        (WebCore::Internals::boundingBox):
     20        (WebCore::Internals::inspectorHighlightRects):
     21        (WebCore::Internals::layoutViewportRect):
     22        (WebCore::Internals::visualViewportRect):
     23        (WebCore::Internals::touchEventRectsForEvent):
     24        (WebCore::Internals::passiveTouchEventListenerRects):
     25        (WebCore::Internals::nonFastScrollableRects):
     26        (WebCore::Internals::selectionBounds):
     27        * testing/Internals.h:
     28        * testing/Internals.idl:
     29
    1302017-04-28  Youenn Fablet  <youenn@apple.com>
    231
  • trunk/Source/WebCore/dom/DOMRect.h

    r215946 r215956  
    5959};
    6060
    61 Vector<Ref<DOMRect>> createDOMRectVector(const Vector<FloatQuad>&);
     61WEBCORE_EXPORT Vector<Ref<DOMRect>> createDOMRectVector(const Vector<FloatQuad>&);
    6262
    6363}
  • trunk/Source/WebCore/dom/DOMRect.idl

    r207438 r215956  
    2929    Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
    3030        optional unrestricted double width = 0, optional unrestricted double height = 0),
     31    ExportMacro=WEBCORE_EXPORT,
    3132    Exposed=(Window,Worker),
    3233    ImplementationLacksVTable
  • trunk/Source/WebCore/page/Page.cpp

    r215607 r215956  
    2929#include "Chrome.h"
    3030#include "ChromeClient.h"
    31 #include "ClientRectList.h"
    3231#include "ConstantPropertyMap.h"
    3332#include "ContextMenuClient.h"
    3433#include "ContextMenuController.h"
     34#include "DOMRect.h"
    3535#include "DatabaseProvider.h"
    3636#include "DiagnosticLoggingClient.h"
     
    406406}
    407407
    408 Ref<ClientRectList> Page::nonFastScrollableRects()
     408Vector<Ref<DOMRect>> Page::nonFastScrollableRects()
    409409{
    410410    if (Document* document = m_mainFrame->document())
     
    422422        quads[i] = FloatRect(rects[i]);
    423423
    424     return ClientRectList::create(quads);
    425 }
    426 
    427 Ref<ClientRectList> Page::touchEventRectsForEvent(const String& eventName)
     424    return createDOMRectVector(quads);
     425}
     426
     427Vector<Ref<DOMRect>> Page::touchEventRectsForEvent(const String& eventName)
    428428{
    429429    if (Document* document = m_mainFrame->document()) {
     
    445445        quads[i] = FloatRect(rects[i]);
    446446
    447     return ClientRectList::create(quads);
    448 }
    449 
    450 Ref<ClientRectList> Page::passiveTouchEventListenerRects()
     447    return createDOMRectVector(quads);
     448}
     449
     450Vector<Ref<DOMRect>> Page::passiveTouchEventListenerRects()
    451451{
    452452    if (Document* document = m_mainFrame->document()) {
     
    465465        quads[i] = FloatRect(rects[i]);
    466466
    467     return ClientRectList::create(quads);
     467    return createDOMRectVector(quads);
    468468}
    469469
  • trunk/Source/WebCore/page/Page.h

    r215607 r215956  
    8282class Chrome;
    8383class ChromeClient;
    84 class ClientRectList;
    8584class Color;
    8685class ContextMenuClient;
    8786class ContextMenuController;
     87class DOMRect;
    8888class DatabaseProvider;
    8989class DiagnosticLoggingClient;
     
    240240    WEBCORE_EXPORT String scrollingStateTreeAsText();
    241241    WEBCORE_EXPORT String synchronousScrollingReasonsAsText();
    242     WEBCORE_EXPORT Ref<ClientRectList> nonFastScrollableRects();
    243 
    244     WEBCORE_EXPORT Ref<ClientRectList> touchEventRectsForEvent(const String& eventName);
    245     WEBCORE_EXPORT Ref<ClientRectList> passiveTouchEventListenerRects();
     242    WEBCORE_EXPORT Vector<Ref<DOMRect>> nonFastScrollableRects();
     243
     244    WEBCORE_EXPORT Vector<Ref<DOMRect>> touchEventRectsForEvent(const String& eventName);
     245    WEBCORE_EXPORT Vector<Ref<DOMRect>> passiveTouchEventListenerRects();
    246246
    247247    Settings& settings() const { return *m_settings; }
  • trunk/Source/WebCore/testing/Internals.cpp

    r215929 r215956  
    4141#include "CachedImage.h"
    4242#include "CachedResourceLoader.h"
    43 #include "ClientRect.h"
    44 #include "ClientRectList.h"
    4543#include "ComposedTreeIterator.h"
    4644#include "Cursor.h"
    4745#include "DOMPath.h"
     46#include "DOMRect.h"
    4847#include "DOMStringList.h"
    4948#include "DOMWindow.h"
     
    13291328#endif
    13301329
    1331 ExceptionOr<Ref<ClientRect>> Internals::absoluteCaretBounds()
     1330ExceptionOr<Ref<DOMRect>> Internals::absoluteCaretBounds()
    13321331{
    13331332    Document* document = contextDocument();
     
    13351334        return Exception { INVALID_ACCESS_ERR };
    13361335
    1337     return ClientRect::create(document->frame()->selection().absoluteCaretBounds());
    1338 }
    1339 
    1340 Ref<ClientRect> Internals::boundingBox(Element& element)
     1336    return DOMRect::create(document->frame()->selection().absoluteCaretBounds());
     1337}
     1338
     1339Ref<DOMRect> Internals::boundingBox(Element& element)
    13411340{
    13421341    element.document().updateLayoutIgnorePendingStylesheets();
    13431342    auto renderer = element.renderer();
    13441343    if (!renderer)
    1345         return ClientRect::create();
    1346     return ClientRect::create(renderer->absoluteBoundingBoxRectIgnoringTransforms());
    1347 }
    1348 
    1349 ExceptionOr<Ref<ClientRectList>> Internals::inspectorHighlightRects()
     1344        return DOMRect::create();
     1345    return DOMRect::create(renderer->absoluteBoundingBoxRectIgnoringTransforms());
     1346}
     1347
     1348ExceptionOr<Vector<Ref<DOMRect>>> Internals::inspectorHighlightRects()
    13501349{
    13511350    Document* document = contextDocument();
     
    13551354    Highlight highlight;
    13561355    document->page()->inspectorController().getHighlight(highlight, InspectorOverlay::CoordinateSystem::View);
    1357     return ClientRectList::create(highlight.quads);
     1356    return createDOMRectVector(highlight.quads);
    13581357}
    13591358
     
    14971496}
    14981497
    1499 ExceptionOr<Ref<ClientRect>> Internals::layoutViewportRect()
     1498ExceptionOr<Ref<DOMRect>> Internals::layoutViewportRect()
    15001499{
    15011500    Document* document = contextDocument();
     
    15061505
    15071506    auto& frameView = *document->view();
    1508     return ClientRect::create(frameView.layoutViewportRect());
    1509 }
    1510 
    1511 ExceptionOr<Ref<ClientRect>> Internals::visualViewportRect()
     1507    return DOMRect::create(frameView.layoutViewportRect());
     1508}
     1509
     1510ExceptionOr<Ref<DOMRect>> Internals::visualViewportRect()
    15121511{
    15131512    Document* document = contextDocument();
     
    15181517
    15191518    auto& frameView = *document->view();
    1520     return ClientRect::create(frameView.visualViewportRect());
     1519    return DOMRect::create(frameView.visualViewportRect());
    15211520}
    15221521
     
    17911790}
    17921791
    1793 ExceptionOr<Ref<ClientRectList>> Internals::touchEventRectsForEvent(const String& eventName)
     1792ExceptionOr<Vector<Ref<DOMRect>>> Internals::touchEventRectsForEvent(const String& eventName)
    17941793{
    17951794    Document* document = contextDocument();
     
    18001799}
    18011800
    1802 ExceptionOr<Ref<ClientRectList>> Internals::passiveTouchEventListenerRects()
     1801ExceptionOr<Vector<Ref<DOMRect>>> Internals::passiveTouchEventListenerRects()
    18031802{
    18041803    Document* document = contextDocument();
     
    23222321}
    23232322
    2324 ExceptionOr<RefPtr<ClientRectList>> Internals::nonFastScrollableRects() const
     2323ExceptionOr<Vector<Ref<DOMRect>>> Internals::nonFastScrollableRects() const
    23252324{
    23262325    Document* document = contextDocument();
     
    23302329    Page* page = document->page();
    23312330    if (!page)
    2332         return nullptr;
    2333 
    2334     return RefPtr<ClientRectList> { page->nonFastScrollableRects() };
     2331        return Vector<Ref<DOMRect>> { };
     2332
     2333    return page->nonFastScrollableRects();
    23352334}
    23362335
     
    31233122#endif
    31243123
    3125 ExceptionOr<Ref<ClientRect>> Internals::selectionBounds()
     3124ExceptionOr<Ref<DOMRect>> Internals::selectionBounds()
    31263125{
    31273126    Document* document = contextDocument();
     
    31293128        return Exception { INVALID_ACCESS_ERR };
    31303129
    3131     return ClientRect::create(document->frame()->selection().selectionBounds());
     3130    return DOMRect::create(document->frame()->selection().selectionBounds());
    31323131}
    31333132
  • trunk/Source/WebCore/testing/Internals.h

    r215929 r215956  
    4343
    4444class AudioContext;
    45 class ClientRect;
    46 class ClientRectList;
     45class DOMRect;
    4746class DOMURL;
    4847class DOMWindow;
     
    180179    ExceptionOr<void> setFormControlStateOfPreviousHistoryItem(const Vector<String>&);
    181180
    182     ExceptionOr<Ref<ClientRect>> absoluteCaretBounds();
    183 
    184     Ref<ClientRect> boundingBox(Element&);
    185 
    186     ExceptionOr<Ref<ClientRectList>> inspectorHighlightRects();
     181    ExceptionOr<Ref<DOMRect>> absoluteCaretBounds();
     182
     183    Ref<DOMRect> boundingBox(Element&);
     184
     185    ExceptionOr<Vector<Ref<DOMRect>>> inspectorHighlightRects();
    187186    ExceptionOr<String> inspectorHighlightObject();
    188187
     
    201200    ExceptionOr<void> setScrollViewPosition(int x, int y);
    202201
    203     ExceptionOr<Ref<ClientRect>> layoutViewportRect();
    204     ExceptionOr<Ref<ClientRect>> visualViewportRect();
     202    ExceptionOr<Ref<DOMRect>> layoutViewportRect();
     203    ExceptionOr<Ref<DOMRect>> visualViewportRect();
    205204
    206205    ExceptionOr<void> setViewBaseBackgroundColor(const String& colorValue);
     
    244243    ExceptionOr<unsigned> touchEventHandlerCount();
    245244
    246     ExceptionOr<Ref<ClientRectList>> touchEventRectsForEvent(const String&);
    247     ExceptionOr<Ref<ClientRectList>> passiveTouchEventListenerRects();
     245    ExceptionOr<Vector<Ref<DOMRect>>> touchEventRectsForEvent(const String&);
     246    ExceptionOr<Vector<Ref<DOMRect>>> passiveTouchEventListenerRects();
    248247
    249248    ExceptionOr<RefPtr<NodeList>> nodesFromRect(Document&, int x, int y, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding, bool ignoreClipping, bool allowShadowContent, bool allowChildFrameContent) const;
     
    299298    ExceptionOr<String> scrollingStateTreeAsText() const;
    300299    ExceptionOr<String> mainThreadScrollingReasons() const;
    301     ExceptionOr<RefPtr<ClientRectList>> nonFastScrollableRects() const;
     300    ExceptionOr<Vector<Ref<DOMRect>>> nonFastScrollableRects() const;
    302301
    303302    ExceptionOr<void> setElementUsesDisplayListDrawing(Element&, bool usesDisplayListDrawing);
     
    450449#endif
    451450
    452     ExceptionOr<Ref<ClientRect>> selectionBounds();
     451    ExceptionOr<Ref<DOMRect>> selectionBounds();
    453452
    454453#if ENABLE(VIBRATION)
  • trunk/Source/WebCore/testing/Internals.idl

    r215929 r215956  
    149149    [MayThrowException] void setFormControlStateOfPreviousHistoryItem(sequence<DOMString> values);
    150150
    151     [MayThrowException] ClientRect absoluteCaretBounds();
    152 
    153     ClientRect boundingBox(Element element);
    154 
    155     [MayThrowException] ClientRectList inspectorHighlightRects();
     151    [MayThrowException] DOMRect absoluteCaretBounds();
     152
     153    DOMRect boundingBox(Element element);
     154
     155    [MayThrowException] sequence<DOMRect> inspectorHighlightRects();
    156156    [MayThrowException] DOMString inspectorHighlightObject();
    157157
     
    168168    [MayThrowException] void setScrollViewPosition(long x, long y);
    169169
    170     [MayThrowException] ClientRect layoutViewportRect();
    171     [MayThrowException] ClientRect visualViewportRect();
     170    [MayThrowException] DOMRect layoutViewportRect();
     171    [MayThrowException] DOMRect visualViewportRect();
    172172
    173173    [MayThrowException] void setViewBaseBackgroundColor(DOMString colorValue);
     
    216216    [MayThrowException] unsigned long touchEventHandlerCount();
    217217
    218     [MayThrowException] ClientRectList touchEventRectsForEvent(DOMString eventName);
    219     [MayThrowException] ClientRectList passiveTouchEventListenerRects();
     218    [MayThrowException] sequence<DOMRect> touchEventRectsForEvent(DOMString eventName);
     219    [MayThrowException] sequence<DOMRect> passiveTouchEventListenerRects();
    220220
    221221    [MayThrowException] NodeList? nodesFromRect(Document document, long x, long y,
     
    274274    [MayThrowException] DOMString scrollingStateTreeAsText();
    275275    [MayThrowException] DOMString mainThreadScrollingReasons(); // FIXME: rename to synchronousScrollingReasons().
    276     [MayThrowException] ClientRectList? nonFastScrollableRects();
     276    [MayThrowException] sequence<DOMRect> nonFastScrollableRects();
    277277
    278278    [MayThrowException] DOMString repaintRectsAsText();
     
    433433    boolean isPluginSnapshotted(Element element);
    434434
    435     [MayThrowException] ClientRect selectionBounds();
     435    [MayThrowException] DOMRect selectionBounds();
    436436
    437437    [Conditional=MEDIA_SOURCE] void initializeMockMediaSource();
Note: See TracChangeset for help on using the changeset viewer.