Changeset 215989 in webkit
- Timestamp:
- Apr 30, 2017 11:12:30 AM (7 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r215988 r215989 1 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [ATK] Implement support for aria-autocomplete 4 https://bugs.webkit.org/show_bug.cgi?id=171167 5 6 Reviewed by Chris Fleizach. 7 8 * accessibility/gtk/aria-autocomplete-expected.txt: Added. 9 * accessibility/gtk/aria-autocomplete.html: Added. 10 1 11 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r215988 r215989 1 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [ATK] Implement support for aria-autocomplete 4 https://bugs.webkit.org/show_bug.cgi?id=171167 5 6 Reviewed by Chris Fleizach. 7 8 Expose ATK_STATE_SUPPORTS_AUTOCOMPLETION in the state set, and the value 9 of aria-autocomplete as an object attribute, for elements which indicate 10 they support autocompletion. 11 12 Test: accessibility/gtk/aria-autocomplete.html 13 14 * accessibility/AccessibilityObject.cpp: 15 (WebCore::AccessibilityObject::supportsARIAAutoComplete): 16 (WebCore::AccessibilityObject::ariaAutoCompleteValue): 17 * accessibility/AccessibilityObject.h: 18 * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: 19 (webkitAccessibleGetAttributes): 20 (setAtkStateSetFromCoreObject): 21 * html/HTMLAttributeNames.in: 22 1 23 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 24 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r215975 r215989 1612 1612 1613 1613 return getAttribute(aria_readonlyAttr).string().convertToASCIILowercase(); 1614 } 1615 1616 bool AccessibilityObject::supportsARIAAutoComplete() const 1617 { 1618 return isARIATextControl() && hasAttribute(aria_autocompleteAttr); 1619 } 1620 1621 String AccessibilityObject::ariaAutoCompleteValue() const 1622 { 1623 const AtomicString& autoComplete = getAttribute(aria_autocompleteAttr); 1624 if (equalLettersIgnoringASCIICase(autoComplete, "inline") 1625 || equalLettersIgnoringASCIICase(autoComplete, "list") 1626 || equalLettersIgnoringASCIICase(autoComplete, "both")) 1627 return autoComplete; 1628 1629 return "none"; 1614 1630 } 1615 1631 -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r215975 r215989 963 963 bool supportsARIAReadOnly() const; 964 964 String ariaReadOnlyValue() const; 965 966 bool supportsARIAAutoComplete() const; 967 String ariaAutoCompleteValue() const; 965 968 966 969 bool supportsARIAAttributes() const; -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r215988 r215989 400 400 if (!placeholder.isEmpty()) 401 401 attributeSet = addToAtkAttributeSet(attributeSet, "placeholder-text", placeholder.utf8().data()); 402 403 if (coreObject->supportsARIAAutoComplete()) 404 attributeSet = addToAtkAttributeSet(attributeSet, "autocomplete", coreObject->ariaAutoCompleteValue().utf8().data()); 402 405 403 406 if (coreObject->supportsARIAHasPopup()) … … 872 875 // TODO: ATK_STATE_SENSITIVE 873 876 877 if (coreObject->supportsARIAAutoComplete() && coreObject->ariaAutoCompleteValue() != "none") 878 atk_state_set_add_state(stateSet, ATK_STATE_SUPPORTS_AUTOCOMPLETION); 879 874 880 if (coreObject->isVisited()) 875 881 atk_state_set_add_state(stateSet, ATK_STATE_VISITED); -
trunk/Source/WebCore/html/HTMLAttributeNames.in
r215929 r215989 16 16 aria-activedescendant 17 17 aria-atomic 18 aria-autocomplete 18 19 aria-busy 19 20 aria-checked -
trunk/Tools/ChangeLog
r215988 r215989 1 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [ATK] Implement support for aria-autocomplete 4 https://bugs.webkit.org/show_bug.cgi?id=171167 5 6 Reviewed by Chris Fleizach. 7 8 Add "AXSupportsAutoCompletion" attribute so the presence of 9 ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested. 10 11 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: 12 (WTR::AccessibilityUIElement::boolAttributeValue): 13 1 14 2017-04-30 Joanmarie Diggs <jdiggs@igalia.com> 2 15 -
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
r215988 r215989 1113 1113 if (attributeString == "AXSelected") 1114 1114 return checkElementState(m_element.get(), ATK_STATE_SELECTED); 1115 if (attributeString == "AXSupportsAutoCompletion") 1116 return checkElementState(m_element.get(), ATK_STATE_SUPPORTS_AUTOCOMPLETION); 1115 1117 if (attributeString == "AXVisited") 1116 1118 return checkElementState(m_element.get(), ATK_STATE_VISITED);
Note: See TracChangeset
for help on using the changeset viewer.