Changeset 216049 in webkit

Timestamp:

May 1, 2017 6:00:35 PM (7 years ago)

Author:

ddkilzer@apple.com

Message:

Stop using sprintf() in JavaScriptCore debugger
<​https://webkit.org/b/171512>

Reviewed by Keith Miller.

Source/JavaScriptCore:

• disassembler/udis86/udis86.c:

(ud_insn_hex): Switch from sprintf() to snprintf().

Tools:

• Scripts/webkitpy/style/checker.py:

(_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
Source/JavaScriptCore/disassembler/udis86/ is generated code.

Location:

trunk

Files:

• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/disassembler/udis86/udis86.c (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/style/checker.py (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-05-01  David Kilzer  <ddkilzer@apple.com>
+
+        Stop using sprintf() in JavaScriptCore debugger
+        <https://webkit.org/b/171512>
+
+        Reviewed by Keith Miller.
+
+        * disassembler/udis86/udis86.c:
+        (ud_insn_hex): Switch from sprintf() to snprintf().
+
 2017-04-21  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/disassembler/udis86/udis86.c

@@ -168 +168 @@
     unsigned int i;
     const unsigned char *src_ptr = ud_insn_ptr(u);
-    char* src_hex;
-    src_hex = (char*) u->insn_hexcode;
+    char* src_hex = (char*) u->insn_hexcode;
+    char* const src_hex_base = src_hex;
     /* for each byte used to decode instruction */
     for (i = 0; i < ud_insn_len(u) && i < sizeof(u->insn_hexcode) / 2;
          ++i, ++src_ptr) {
-      sprintf(src_hex, "%02x", *src_ptr & 0xFF);
+      snprintf(src_hex, sizeof(u->insn_hexcode) - (src_hex - src_hex_base), "%02x", *src_ptr & 0xFF);
       src_hex += 2;
     }

trunk/Tools/ChangeLog

@@ +1 @@
+2017-05-01  David Kilzer  <ddkilzer@apple.com>
+
+        Stop using sprintf() in JavaScriptCore debugger
+        <https://webkit.org/b/171512>
+
+        Reviewed by Keith Miller.
+
+        * Scripts/webkitpy/style/checker.py:
+        (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
+        Source/JavaScriptCore/disassembler/udis86/ is generated code.
+
 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -2 +2 @@
 # Copyright (C) 2010 Chris Jerdonek (chris.jerdonek@gmail.com)
 # Copyright (C) 2010 ProFUSION embedded systems
-# Copyright (C) 2013, 2015 Apple Inc. All rights reserved.
+# Copyright (C) 2013-2017 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -231 +231 @@
       "+pep8/W291",  # Trailing white space
       "+whitespace/carriage_return"]),
+
+    ([# Source/JavaScriptCore/disassembler/udis86/ is generated code.
+      os.path.join('Source', 'JavaScriptCore', 'disassembler', 'udis86')],
+     ["-readability/naming/underscores",
+      "-whitespace/declaration",
+      "-whitespace/indent"]),
 
     ([# There is no way to avoid the symbols __jit_debug_register_code