Changeset 216132 in webkit

Timestamp:

May 3, 2017 12:27:06 PM (7 years ago)

Author:

beidson@apple.com

Message:

Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge.
​https://bugs.webkit.org/show_bug.cgi?id=171607

Reviewed by Andy Estes.

To test this fix we'd need the combination of an HTTPD inside API tests, so no test for now.

• UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::hasOnlySecureContent): If the state is provisional, check the provisional URL instead.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/PageLoadState.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-05-03  Brady Eidson  <beidson@apple.com>
+
+        Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge.
+        https://bugs.webkit.org/show_bug.cgi?id=171607
+
+        Reviewed by Andy Estes.
+        
+        To test this fix we'd need the combination of an HTTPD inside API tests, so no test for now.
+
+        * UIProcess/PageLoadState.cpp:
+        (WebKit::PageLoadState::hasOnlySecureContent): If the state is provisional, check the provisional URL instead.
+
 2017-05-03  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/UIProcess/PageLoadState.cpp

@@ -206 +206 @@
         return false;
 
+    if (data.state == State::Provisional)
+        return WebCore::protocolIs(data.provisionalURL, "https");
+
     return WebCore::protocolIs(data.url, "https");
 }