Changeset 216133 in webkit

Timestamp:

May 3, 2017 12:27:09 PM (7 years ago)

Author:

jiewen_tan@apple.com

Message:

ASSERTION FAILED: m_scriptExecutionContext->isContextThread() seen with LayoutTest crypto/workers/crypto-random-values-limits-worker.html
​https://bugs.webkit.org/show_bug.cgi?id=171462
<rdar://problem/31906859>

Reviewed by Brent Fulgham.

Covered by existing tests.

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
Clear Crypto early in destruction since its ContextDestructionObserver
destruction makes checks about the WorkerThread.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/WorkerGlobalScope.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-03  Jiewen Tan  <jiewen_tan@apple.com>
+
+        ASSERTION FAILED: m_scriptExecutionContext->isContextThread() seen with LayoutTest crypto/workers/crypto-random-values-limits-worker.html
+        https://bugs.webkit.org/show_bug.cgi?id=171462
+        <rdar://problem/31906859>
+
+        Reviewed by Brent Fulgham.
+
+        Covered by existing tests.
+
+        * workers/WorkerGlobalScope.cpp:
+        (WebCore::WorkerGlobalScope::~WorkerGlobalScope):
+        Clear Crypto early in destruction since its ContextDestructionObserver
+        destruction makes checks about the WorkerThread.
+
 2017-05-03  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/workers/WorkerGlobalScope.cpp

@@ -102 +102 @@
 #endif
 
+    m_crypto = nullptr;
+
     // Notify proxy that we are going away. This can free the WorkerThread object, so do not access it after this.
     thread().workerReportingProxy().workerGlobalScopeDestroyed();