Changeset 216235 in webkit


Ignore:
Timestamp:
May 4, 2017 11:37:48 PM (7 years ago)
Author:
BJ Burg
Message:

lldb_webkit.py should provide a type summary for WebCore::URL
https://bugs.webkit.org/show_bug.cgi?id=171670

Reviewed by Jer Noble.

Just print out the underlying string using the WTFString provider.

  • lldb/lldb_webkit.py:

(lldb_init_module):
(WebCoreURL_SummaryProvider):
(WebCoreURLProvider):
(WebCoreURLProvider.
init):
(WebCoreURLProvider.to_string):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r216234 r216235  
     12017-05-04  Brian Burg  <bburg@apple.com>
     2
     3        lldb_webkit.py should provide a type summary for WebCore::URL
     4        https://bugs.webkit.org/show_bug.cgi?id=171670
     5
     6        Reviewed by Jer Noble.
     7
     8        Just print out the underlying string using the WTFString provider.
     9
     10        * lldb/lldb_webkit.py:
     11        (__lldb_init_module):
     12        (WebCoreURL_SummaryProvider):
     13        (WebCoreURLProvider):
     14        (WebCoreURLProvider.__init__):
     15        (WebCoreURLProvider.to_string):
     16
    1172017-05-04  Commit Queue  <commit-queue@webkit.org>
    218
  • trunk/Tools/lldb/lldb_webkit.py

    r202604 r216235  
    1 # Copyright (C) 2012 Apple. All rights reserved.
     1# Copyright (C) 2012-2017 Apple Inc. All rights reserved.
    22#
    33# Redistribution and use in source and binary forms, with or without
     
    4747    debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutSize_SummaryProvider WebCore::LayoutSize')
    4848    debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreLayoutPoint_SummaryProvider WebCore::LayoutPoint')
     49    debugger.HandleCommand('type summary add -F lldb_webkit.WebCoreURL_SummaryProvider WebCore::URL')
    4950
    5051def WTFString_SummaryProvider(valobj, dict):
     
    8990
    9091
     92def WebCoreURL_SummaryProvider(valobj, dict):
     93    provider = WebCoreURLProvider(valobj, dict)
     94    return "{ %s }" % provider.to_string()
     95
     96
    9197def WebCoreLayoutUnit_SummaryProvider(valobj, dict):
    9298    provider = WebCoreLayoutUnitProvider(valobj, dict)
     
    156162# def WTFVector_SummaryProvider(valobj, dict):
    157163# def WTFCString_SummaryProvider(valobj, dict):
    158 # def WebCoreKURLGooglePrivate_SummaryProvider(valobj, dict):
    159164# def WebCoreQualifiedName_SummaryProvider(valobj, dict):
    160165# def JSCIdentifier_SummaryProvider(valobj, dict):
     
    304309        return WebCoreLayoutUnitProvider(self.valobj.GetChildMemberWithName('m_y'), dict).to_string()
    305310
     311
     312class WebCoreURLProvider:
     313    "Print a WebCore::URL"
     314    def __init__(self, valobj, dict):
     315        self.valobj = valobj
     316
     317    def to_string(self):
     318        return WTFStringProvider(self.valobj.GetChildMemberWithName('m_string'), dict).to_string()
    306319
    307320class WTFVectorProvider:
Note: See TracChangeset for help on using the changeset viewer.