Changeset 216285 in webkit

Timestamp:

May 5, 2017 3:50:56 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

TURNS gathering is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=171747

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-05
Reviewed by Eric Carlson.

Did manual testing on real TURNS servers.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-05  Youenn Fablet  <youenn@apple.com>
+
+        TURNS gathering is not working properly
+        https://bugs.webkit.org/show_bug.cgi?id=171747
+
+        Reviewed by Eric Carlson.
+
+        Did manual testing on real TURNS servers.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+        (WebCore::configurationFromMediaEndpointConfiguration): Disabling TURNS servers gathering.
+
 2017-05-05  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp

@@ -89 +89 @@
         iceServer.username = server.username.utf8().data();
         iceServer.password = server.credential.utf8().data();
-        for (auto& url : server.urls)
-            iceServer.urls.push_back({ url.string().utf8().data() });
-        rtcConfiguration.servers.push_back(WTFMove(iceServer));
+        for (auto& url : server.urls) {
+            // FIXME: If TURNS is failing, the whole ICE candidate gathering is failing.
+            // We should fix that and reactivate TURNS gathering.
+            if (!url.protocolIs("turns"))
+                iceServer.urls.push_back({ url.string().utf8().data() });
+        }
+        if (iceServer.urls.size())
+            rtcConfiguration.servers.push_back(WTFMove(iceServer));
     }