Changeset 216338 in webkit
- Timestamp:
- May 6, 2017 8:25:20 PM (7 years ago)
- Location:
- trunk/Source
- Files:
-
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r216336 r216338 1 2017-05-06 Tim Horton <timothy_horton@apple.com> 2 3 Reduce the number of includes in WebPage.h and WebProcess.h 4 https://bugs.webkit.org/show_bug.cgi?id=171779 5 6 Reviewed by Sam Weinig. 7 8 * page/TextIndicator.h: 9 1 10 2017-05-06 Alexey Proskuryakov <ap@apple.com> 2 11 -
trunk/Source/WebCore/page/TextIndicator.h
r214231 r216338 38 38 39 39 // FIXME: Move PresentationTransition to TextIndicatorWindow, because it's about presentation. 40 enum class TextIndicatorPresentationTransition {40 enum class TextIndicatorPresentationTransition : uint8_t { 41 41 None, 42 42 -
trunk/Source/WebKit2/ChangeLog
r216336 r216338 1 2017-05-06 Tim Horton <timothy_horton@apple.com> 2 3 Reduce the number of includes in WebPage.h and WebProcess.h 4 https://bugs.webkit.org/show_bug.cgi?id=171779 5 6 Reviewed by Sam Weinig. 7 8 * WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h: 9 * WebProcess/Network/NetworkProcessConnection.cpp: 10 * WebProcess/Network/webrtc/LibWebRTCProvider.cpp: 11 * WebProcess/Network/webrtc/LibWebRTCResolver.cpp: 12 * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: 13 * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: 14 * WebProcess/WebPage/FindController.cpp: 15 * WebProcess/WebPage/WebFrame.cpp: 16 * WebProcess/WebPage/WebPage.cpp: 17 (WebKit::WebPage::disableEnumeratingAllNetworkInterfaces): 18 (WebKit::WebPage::enableEnumeratingAllNetworkInterfaces): 19 (WebKit::WebPage::didReceivePolicyDecision): 20 * WebProcess/WebPage/WebPage.h: 21 (WebKit::WebPage::disableEnumeratingAllNetworkInterfaces): Deleted. 22 (WebKit::WebPage::enableEnumeratingAllNetworkInterfaces): Deleted. 23 * WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h: 24 * WebProcess/WebProcess.cpp: 25 * WebProcess/WebProcess.h: 26 In my measurement, this improves WebKit2 debug clean build time by 27 ~10% for Mac and ~5% for iOS. The most valuable change is the one to 28 remove LibWebRTC headers.. 29 1 30 2017-05-06 Alexey Proskuryakov <ap@apple.com> 2 31 -
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h
r209307 r216338 27 27 28 28 #include <WebCore/EditorInsertAction.h> 29 #include <WebCore/SharedBuffer.h>30 29 #include <WebCore/TextAffinity.h> 31 30 #include <wtf/Forward.h> 31 #include <wtf/Vector.h> 32 32 33 33 namespace WebCore { … … 35 35 class Node; 36 36 class Range; 37 class SharedBuffer; 37 38 } 38 39 -
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp
r214413 r216338 28 28 29 29 #include "DataReference.h" 30 #include "LibWebRTCNetwork.h" 30 31 #include "NetworkConnectionToWebProcessMessages.h" 31 32 #include "WebCoreArgumentCoders.h" -
trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
r213418 r216338 29 29 #if USE(LIBWEBRTC) 30 30 31 #include "LibWebRTCNetwork.h" 31 32 #include "WebProcess.h" 32 33 #include <webrtc/pc/peerconnectionfactory.h> -
trunk/Source/WebKit2/WebProcess/Network/webrtc/LibWebRTCResolver.cpp
r211441 r216338 29 29 #if USE(LIBWEBRTC) 30 30 31 #include "LibWebRTCNetwork.h" 31 32 #include "NetworkProcessConnection.h" 32 33 #include "NetworkRTCProviderMessages.h" -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
r203338 r216338 34 34 #include "WebPage.h" 35 35 #include <WebCore/ContextMenu.h> 36 #include <WebCore/Editor.h> 36 37 #include <WebCore/Event.h> 37 38 #include <WebCore/FrameLoader.h> -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
r192333 r216338 33 33 #import "WebPageProxyMessages.h" 34 34 #import <WebCore/DictionaryLookup.h> 35 #import <WebCore/Editor.h> 35 36 #import <WebCore/FrameView.h> 36 37 #import <WebCore/MainFrame.h> -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm
r206261 r216338 36 36 #import "WebPageProxyMessages.h" 37 37 #import "WebProcess.h" 38 #import <WebCore/Editor.h> 38 39 #import <WebCore/FocusController.h> 39 40 #import <WebCore/Frame.h> -
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp
r214893 r216338 37 37 #include <WebCore/FloatQuad.h> 38 38 #include <WebCore/FocusController.h> 39 #include <WebCore/FrameSelection.h> 39 40 #include <WebCore/FrameView.h> 40 41 #include <WebCore/GraphicsContext.h> -
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
r212312 r216338 54 54 #include <WebCore/Chrome.h> 55 55 #include <WebCore/DocumentLoader.h> 56 #include <WebCore/Editor.h> 56 57 #include <WebCore/EventHandler.h> 57 58 #include <WebCore/File.h> -
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
r216234 r216338 587 587 m_page->rtcController().disableICECandidateFiltering(); 588 588 } 589 590 #if USE(LIBWEBRTC) 591 void WebPage::disableEnumeratingAllNetworkInterfaces() 592 { 593 m_page->libWebRTCProvider().disableEnumeratingAllNetworkInterfaces(); 594 } 595 596 void WebPage::enableEnumeratingAllNetworkInterfaces() 597 { 598 m_page->libWebRTCProvider().enableEnumeratingAllNetworkInterfaces(); 599 } 600 #endif 589 601 #endif 590 602 … … 2721 2733 } 2722 2734 2723 void WebPage::didReceivePolicyDecision(uint64_t frameID, uint64_t listenerID, uint32_t policyAction, uint64_t navigationID, DownloadIDdownloadID)2735 void WebPage::didReceivePolicyDecision(uint64_t frameID, uint64_t listenerID, uint32_t policyAction, uint64_t navigationID, const DownloadID& downloadID) 2724 2736 { 2725 2737 WebFrame* frame = WebProcess::singleton().webFrame(frameID); -
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
r216212 r216338 31 31 #include "APIInjectedBundlePageUIClient.h" 32 32 #include "APIObject.h" 33 #include "Download.h"34 33 #include "EditingRange.h" 35 34 #include "FindController.h" 36 35 #include "GeolocationPermissionRequestManager.h" 37 #include "ImageOptions.h"38 36 #include "InjectedBundlePageFullScreenClient.h" 39 37 #include "InjectedBundlePageLoaderClient.h" … … 45 43 #include "Plugin.h" 46 44 #include "SandboxExtension.h" 47 #include "ShareableBitmap.h"48 45 #include "UserData.h" 49 46 #include "UserMediaPermissionRequestManager.h" 50 47 #include "WebURLSchemeHandler.h" 51 48 #include <WebCore/ActivityState.h> 52 #include <WebCore/DictationAlternative.h>53 #include <WebCore/DictionaryPopupInfo.h>54 #include <WebCore/DragData.h>55 #include <WebCore/Editor.h>56 49 #include <WebCore/FrameLoaderTypes.h> 57 #include <WebCore/HitTestResult.h>58 50 #include <WebCore/HysteresisActivity.h> 59 51 #include <WebCore/IntRect.h> 60 52 #include <WebCore/IntSizeHash.h> 61 #include <WebCore/LibWebRTCProvider.h>62 53 #include <WebCore/Page.h> 63 54 #include <WebCore/PageOverlay.h> 64 55 #include <WebCore/PageVisibilityState.h> 65 #include <WebCore/PlatformMouseEvent.h>66 #include <WebCore/ScrollTypes.h>67 #include <WebCore/TextChecking.h>68 #include <WebCore/TextIndicator.h>69 56 #include <WebCore/UserActivity.h> 70 57 #include <WebCore/UserContentTypes.h> 71 58 #include <WebCore/UserInterfaceLayoutDirection.h> 72 59 #include <WebCore/UserScriptTypes.h> 73 #include <WebCore/ViewportConfiguration.h>74 60 #include <WebCore/WebCoreKeyboardUIMode.h> 75 61 #include <memory> … … 93 79 #if PLATFORM(IOS) 94 80 #include "GestureTypes.h" 95 #import "WebPageMessages.h" 81 #include "WebPageMessages.h" 82 #include <WebCore/ViewportConfiguration.h> 96 83 #endif 97 84 … … 133 120 class GraphicsContext; 134 121 class Frame; 122 class FrameSelection; 135 123 class FrameView; 136 124 class HTMLPlugInElement; … … 149 137 class URL; 150 138 class VisibleSelection; 139 enum class TextIndicatorPresentationTransition : uint8_t; 140 enum SyntheticClickType : int8_t; 151 141 struct Highlight; 152 142 struct KeypressCommand; 153 143 struct TextCheckingResult; 144 struct ViewportArguments; 154 145 155 146 #if ENABLE(VIDEO) && USE(GSTREAMER) … … 160 151 namespace WebKit { 161 152 class DrawingArea; 153 class DownloadID; 154 class GamepadData; 162 155 class InjectedBundleBackForwardList; 163 156 class NotificationPermissionRequestManager; … … 197 190 struct EditingRange; 198 191 struct EditorState; 199 class GamepadData;200 192 struct InteractionInformationAtPosition; 201 193 struct InteractionInformationRequest; … … 206 198 struct WebPreferencesStore; 207 199 struct WebSelectionData; 200 201 typedef uint32_t SnapshotOptions; 208 202 209 203 #if PLATFORM(COCOA) … … 1119 1113 void updatePreferences(const WebPreferencesStore&); 1120 1114 1121 void didReceivePolicyDecision(uint64_t frameID, uint64_t listenerID, uint32_t policyAction, uint64_t navigationID, DownloadID);1115 void didReceivePolicyDecision(uint64_t frameID, uint64_t listenerID, uint32_t policyAction, uint64_t navigationID, const DownloadID&); 1122 1116 void setUserAgent(const String&); 1123 1117 void setCustomTextEncodingName(const String&); … … 1194 1188 void enableICECandidateFiltering(); 1195 1189 #if USE(LIBWEBRTC) 1196 void disableEnumeratingAllNetworkInterfaces() { m_page->libWebRTCProvider().disableEnumeratingAllNetworkInterfaces(); }1197 void enableEnumeratingAllNetworkInterfaces() { m_page->libWebRTCProvider().enableEnumeratingAllNetworkInterfaces(); }1190 void disableEnumeratingAllNetworkInterfaces(); 1191 void enableEnumeratingAllNetworkInterfaces(); 1198 1192 #endif 1199 1193 #endif -
trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
r210845 r216338 38 38 #include "WindowsKeyboardCodes.h" 39 39 #include <WebCore/BackForwardController.h> 40 #include <WebCore/Editor.h> 40 41 #include <WebCore/EventHandler.h> 41 42 #include <WebCore/FocusController.h> … … 47 48 #include <WebCore/PlatformKeyboardEvent.h> 48 49 #include <WebCore/Settings.h> 50 #include <WebCore/SharedBuffer.h> 49 51 #include <WebCore/UserAgent.h> 50 52 #include <wtf/glib/GUniquePtr.h> -
trunk/Source/WebKit2/WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h
r201224 r216338 30 30 #import <WebCore/GraphicsContext.h> 31 31 #import <WebCore/PageOverlay.h> 32 33 namespace WebCore { 34 class TextIndicator; 35 } 32 #import <WebCore/TextIndicator.h> 36 33 37 34 namespace WebKit { -
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
r216234 r216338 35 35 #include "EventDispatcher.h" 36 36 #include "InjectedBundle.h" 37 #include "LibWebRTCNetwork.h" 37 38 #include "Logging.h" 38 39 #include "NetworkConnectionToWebProcessMessages.h" -
trunk/Source/WebKit2/WebProcess/WebProcess.h
r215941 r216338 28 28 #include "CacheModel.h" 29 29 #include "ChildProcess.h" 30 #include "DrawingArea.h"31 #include "LibWebRTCNetwork.h"32 30 #include "PluginProcessConnectionManager.h" 33 31 #include "ResourceCachesToClear.h" 34 32 #include "SandboxExtension.h" 35 #include "SharedMemory.h"36 33 #include "TextCheckerState.h" 37 34 #include "ViewUpdateDispatcher.h" 38 #include "VisitedLinkTable.h"39 35 #include "WebInspectorInterruptDispatcher.h" 36 #include <WebCore/ActivityState.h> 40 37 #include <WebCore/HysteresisActivity.h> 41 #include <WebCore/ResourceLoadStatisticsStore.h>42 38 #include <WebCore/SessionID.h> 43 39 #include <WebCore/Timer.h> … … 69 65 class SessionID; 70 66 class UserGestureToken; 67 class ResourceLoadStatisticsStore; 71 68 struct PluginInfo; 72 69 struct SecurityOriginData; … … 79 76 class GamepadData; 80 77 class InjectedBundle; 78 class LibWebRTCNetwork; 81 79 class NetworkProcessConnection; 82 80 class ObjCObjectGraph;
Note: See TracChangeset
for help on using the changeset viewer.