Changeset 216343 in webkit

Timestamp:

May 7, 2017 2:29:45 AM (7 years ago)

Author:

Michael Catanzaro

Message:

[GTK] Cannot sign in with new Google sign-in page
​https://bugs.webkit.org/show_bug.cgi?id=171770

Reviewed by Carlos Garcia Campos.

Google's new authentication page does not work with the Firefox user
agent that's required to make various Google websites work. Special-case
accounts.google.com so that it receives our standard user agent.

• platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/UserAgentQuirks.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Cannot sign in with new Google sign-in page
+        https://bugs.webkit.org/show_bug.cgi?id=171770
+
+        Reviewed by Carlos Garcia Campos.
+
+        Google's new authentication page does not work with the Firefox user
+        agent that's required to make various Google websites work. Special-case
+        accounts.google.com so that it receives our standard user agent.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::isGoogle):
+        (WebCore::urlRequiresFirefoxBrowser):
+
 2017-05-06  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -42 +42 @@
     // https://webkit.org/b/142074 carefully before changing. Test that Earth
     // view is available in Google Maps. Test Google Calendar. Test downloading
-    // the Hangouts browser plugin. Change platformVersionForUAString() to
-    // return "FreeBSD amd64" and test Maps and Calendar again.
+    // the Hangouts browser plugin. Test logging out and logging in to a Google
+    // account. Change platformVersionForUAString() to return "FreeBSD amd64"
+    // and test everything again.
     if (baseDomain.startsWith("google."))
         return true;
@@ -76 +77 @@
 static bool urlRequiresFirefoxBrowser(const URL& url)
 {
-    return isGoogle(url);
+    return isGoogle(url) && url.host() != "accounts.google.com";
 }