Changeset 216430 in webkit

Timestamp:

May 8, 2017 10:06:29 AM (7 years ago)

Author:

jfbastien@apple.com

Message:

WebAssembly: don't just emit extended offset adds for patch
​https://bugs.webkit.org/show_bug.cgi?id=171799

Reviewed by Mark Lam.

It isn't necessary to restrict.

• b3/air/AirLowerStackArgs.cpp:

(JSC::B3::Air::lowerStackArgs):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/air/AirLowerStackArgs.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-05-08  JF Bastien  <jfbastien@apple.com>
+
+        WebAssembly: don't just emit extended offset adds for patch
+        https://bugs.webkit.org/show_bug.cgi?id=171799
+
+        Reviewed by Mark Lam.
+
+        It isn't necessary to restrict.
+
+        * b3/air/AirLowerStackArgs.cpp:
+        (JSC::B3::Air::lowerStackArgs):
+
 2017-05-08  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp

@@ -71 +71 @@
         for (unsigned instIndex = 0; instIndex < block->size(); ++instIndex) {
             Inst& inst = block->at(instIndex);
-            bool isPatch = inst.kind.opcode == Patch;
 
             inst.forEachArg(
@@ -78 +77 @@
                         int32_t offsetFromSP = offsetFromFP + code.frameSize();
 
-                        if (isPatch && inst.admitsExtendedOffsetAddr(arg)) {
+                        if (inst.admitsExtendedOffsetAddr(arg)) {
                             // Stackmaps and patchpoints expect addr inputs relative to SP or FP only. We might as well
                             // not even bother generating an addr with valid form for these opcodes since extended offset