Changeset 216436 in webkit

Timestamp:

May 8, 2017 10:39:37 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

TURNS gathering is not working properly
​https://bugs.webkit.org/show_bug.cgi?id=171747

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-08
Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

• Source/webrtc/base/openssladapter.cc: Adding support for SNI in case of TLS ice candidate gathering.

Source/WebCore:

Covered by manual tests.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Reveting TURNS ice server skipping.

Location:

trunk/Source

Files:

• ThirdParty/libwebrtc/ChangeLog (modified) (1 diff)
• ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2017-05-08  Youenn Fablet  <youenn@apple.com>
+
+        TURNS gathering is not working properly
+        https://bugs.webkit.org/show_bug.cgi?id=171747
+
+        Reviewed by Eric Carlson.
+
+        * Source/webrtc/base/openssladapter.cc: Adding support for SNI in case of TLS ice candidate gathering.
+
 2017-04-29  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc

@@ -333 +333 @@
 
   SSL_set_app_data(ssl_, this);
+  // WEBKIT Changes - Start
+  if (ssl_host_name_.length()) {
+    SSL_set_tlsext_host_name(ssl_, ssl_host_name_.c_str());
+  }
+  // WEBKIT Changes - End
 
   SSL_set_bio(ssl_, bio, bio);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-08  Youenn Fablet  <youenn@apple.com>
+
+        TURNS gathering is not working properly
+        https://bugs.webkit.org/show_bug.cgi?id=171747
+
+        Reviewed by Eric Carlson.
+
+        Covered by manual tests.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+        (WebCore::configurationFromMediaEndpointConfiguration): Reveting TURNS ice server skipping.
+
 2017-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp

@@ -89 +89 @@
         iceServer.username = server.username.utf8().data();
         iceServer.password = server.credential.utf8().data();
-        for (auto& url : server.urls) {
-            // FIXME: If TURNS is failing, the whole ICE candidate gathering is failing.
-            // We should fix that and reactivate TURNS gathering.
-            if (!url.protocolIs("turns"))
-                iceServer.urls.push_back({ url.string().utf8().data() });
-        }
-        if (iceServer.urls.size())
-            rtcConfiguration.servers.push_back(WTFMove(iceServer));
+        for (auto& url : server.urls)
+            iceServer.urls.push_back({ url.string().utf8().data() });
+        rtcConfiguration.servers.push_back(WTFMove(iceServer));
     }