Changeset 216474 in webkit

Timestamp:

May 8, 2017 7:46:26 PM (7 years ago)

Author:

Chris Dumez

Message:

Drop [CEReactions] from CharacterData operations
​https://bugs.webkit.org/show_bug.cgi?id=171813

Reviewed by Ryosuke Niwa.

Drop [CEReactions] from CharacterData operations to match the DOM specification:

• ​https://dom.spec.whatwg.org/#interface-characterdata

I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying
those Text child nodes via the CharacterData API could modify the value of an attribute,
requiring us to run attributeChangedCallback for Custom Elements. However, as of
<​https://trac.webkit.org/r216259>, Attr can no longer have Text child nodes.

I have also verified that Blink does not have [CEReactions] for those methods.

No new tests, no expected Web-facing behavior change.

• dom/CharacterData.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/CharacterData.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-08  Chris Dumez  <cdumez@apple.com>
+
+        Drop [CEReactions] from CharacterData operations
+        https://bugs.webkit.org/show_bug.cgi?id=171813
+
+        Reviewed by Ryosuke Niwa.
+
+        Drop [CEReactions] from CharacterData operations to match the DOM specification:
+        - https://dom.spec.whatwg.org/#interface-characterdata
+
+        I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying
+        those Text child nodes via the CharacterData API could modify the value of an attribute,
+        requiring us to run attributeChangedCallback for Custom Elements. However, as of
+        <https://trac.webkit.org/r216259>, Attr can no longer have Text child nodes.
+
+        I have also verified that Blink does not have [CEReactions] for those methods.
+
+        No new tests, no expected Web-facing behavior change.
+
+        * dom/CharacterData.idl:
+
 2017-05-08  Jeremy Jones  <jeremyj@apple.com>
 

trunk/Source/WebCore/dom/CharacterData.idl

@@ -19 +19 @@
 
 interface CharacterData : Node {
-    [CEReactions] attribute [TreatNullAs=EmptyString] DOMString data; // FIXME: Not marked as [CEReactions] in the spec.
+    attribute [TreatNullAs=EmptyString] DOMString data;
     readonly attribute unsigned long length;
     [MayThrowException] DOMString substringData(unsigned long offset, unsigned long count);
-    [CEReactions] void appendData(DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
-    [CEReactions, MayThrowException] void insertData(unsigned long offset, DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
-    [CEReactions, MayThrowException] void deleteData(unsigned long offset, unsigned long count); // FIXME: Not marked as [CEReactions] in the spec.
-    [CEReactions, MayThrowException] void replaceData(unsigned long offset, unsigned long count, DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
+    void appendData(DOMString data);
+    [MayThrowException] void insertData(unsigned long offset, DOMString data);
+    [MayThrowException] void deleteData(unsigned long offset, unsigned long count);
+    [MayThrowException] void replaceData(unsigned long offset, unsigned long count, DOMString data);
 };