Changeset 216672 in webkit


Ignore:
Timestamp:
May 11, 2017 12:56:34 AM (7 years ago)
Author:
jfbastien@apple.com
Message:

WebAssembly: stop supporting 0xD
https://bugs.webkit.org/show_bug.cgi?id=168788
<rdar://problem/31880922>

Reviewed by Saam Barati.

JSTests:

Test that only version 1 is supported.

  • wasm/js-api/version.js: Added.

Source/JavaScriptCore:

Only version 1 is supported by other browsers, and there shouldn't
be any 0xD binaries in the wild anymore.

  • wasm/WasmModuleParser.cpp:
Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r216598 r216672  
     12017-05-11  JF Bastien  <jfbastien@apple.com>
     2
     3        WebAssembly: stop supporting 0xD
     4        https://bugs.webkit.org/show_bug.cgi?id=168788
     5        <rdar://problem/31880922>
     6
     7        Reviewed by Saam Barati.
     8
     9        Test that only version 1 is supported.
     10
     11        * wasm/js-api/version.js: Added.
     12
    1132017-05-10  JF Bastien  <jfbastien@apple.com>
    214
  • trunk/Source/JavaScriptCore/ChangeLog

    r216641 r216672  
     12017-05-11  JF Bastien  <jfbastien@apple.com>
     2
     3        WebAssembly: stop supporting 0xD
     4        https://bugs.webkit.org/show_bug.cgi?id=168788
     5        <rdar://problem/31880922>
     6
     7        Reviewed by Saam Barati.
     8
     9        Only version 1 is supported by other browsers, and there shouldn't
     10        be any 0xD binaries in the wild anymore.
     11
     12        * wasm/WasmModuleParser.cpp:
     13
    1142017-05-09  Sam Weinig  <sam@webkit.org>
    215
  • trunk/Source/JavaScriptCore/wasm/WasmModuleParser.cpp

    r216597 r216672  
    5454    WASM_PARSER_FAIL_IF(!consumeCharacter(0) || !consumeString("asm"), "modules doesn't start with '\\0asm'");
    5555    WASM_PARSER_FAIL_IF(!parseUInt32(versionNumber), "can't parse version number");
    56     if (versionNumber != 0xD) // FIXME Stop supporting version 0xD temporarily. https://bugs.webkit.org/show_bug.cgi?id=168788
    57         WASM_PARSER_FAIL_IF(versionNumber != expectedVersionNumber, "unexpected version number ", versionNumber, " expected ", expectedVersionNumber);
     56    WASM_PARSER_FAIL_IF(versionNumber != expectedVersionNumber, "unexpected version number ", versionNumber, " expected ", expectedVersionNumber);
    5857
    5958    Section previousSection = Section::Custom;
Note: See TracChangeset for help on using the changeset viewer.