Changeset 21682 in webkit


Ignore:
Timestamp:
May 23, 2007 4:19:56 PM (17 years ago)
Author:
kmccullo
Message:

LayoutTests:

Reviewed by Darin.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
Auto-generate JS DOM bindings for HTMLDocument and most of
the rest of HTMLElement

  • Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement.
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/prototype-chain.html:

WebCore:

Reviewed by Darin.

  • rdar://problem/5183523
  • We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open):
  • platform/PlatformString.h: (WebCore::debugPrintString):
Location:
trunk
Files:
9 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r21681 r21682  
    1212        * fast/dom/prototype-chain-expected.txt:
    1313        * fast/dom/prototype-chain.html:
     14
     152007-05-23  Kevin McCullough  <kmccullough@apple.com>
     16
     17        Reviewed by Darin.
     18
     19        - rdar://problem/5183523
     20        - Tests for a fix for a regression with Excel worksheets.  We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
     21
     22        * fast/dom/frame-loading-via-document-write-expected.txt: Added.
     23        * fast/dom/frame-loading-via-document-write.html: Added.
     24        * fast/dom/resources/frame-loading-via-document-write.js: Added.
     25        * fast/dom/resources/green250x50.png: Added.
     26        * fast/dom/resources/success.html: Added.
    1427
    15282007-05-23  Kevin McCullough  <kmccullough@apple.com>
  • trunk/WebCore/ChangeLog

    r21681 r21682  
     12007-05-22  Kevin McCullough  <kmccullough@apple.com>
     2
     3        Reviewed by Darin.
     4
     5        - rdar://problem/5183523
     6        - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
     7
     8        * loader/FrameLoader.cpp:
     9        (WebCore::FrameLoader::load):
     10        (WebCore::FrameLoader::open):
     11        * platform/PlatformString.h:
     12        (WebCore::debugPrintString):
     13
    1142007-05-23  Sam Weinig  <sam@webkit.org>
    215
  • trunk/WebCore/loader/FrameLoader.cpp

    r21612 r21682  
    17821782    HTMLFormElement* submitForm, const HashMap<String, String>& formValues)
    17831783{
     1784    KURL url = request.resourceRequest().url();
     1785
     1786    ASSERT(frame()->document());
     1787    if (!canLoad(url, frame()->document())) {
     1788        FrameLoader::reportLocalLoadFailed(frame()->page(), url.url());
     1789        return;
     1790    }
     1791 
    17841792    String referrer;
    17851793    String argsReferrer = request.resourceRequest().httpReferrer();
     
    17881796    else
    17891797        referrer = m_outgoingReferrer;
    1790  
    1791     bool hideReferrer;
    1792     if (!canLoad(request.resourceRequest().url(), referrer, hideReferrer)) {
    1793         FrameLoader::reportLocalLoadFailed(frame()->page(), request.resourceRequest().url().url());
    1794         return;
    1795     }
    1796 
    1797     if (hideReferrer)
     1798
     1799    if (shouldHideReferrer(url, referrer))
    17981800        referrer = String();
    17991801   
     
    18151817            formState = FormState::create(submitForm, formValues, m_frame);
    18161818       
    1817         load(request.resourceRequest().url(), referrer, loadType,
     1819        load(url, referrer, loadType,
    18181820            request.frameName(), event, formState.release());
    18191821    } else
    1820         post(request.resourceRequest().url(), referrer, request.frameName(),
     1822        post(url, referrer, request.frameName(),
    18211823            request.resourceRequest().httpBody(), request.resourceRequest().httpContentType(), event, submitForm, formValues);
    18221824
     
    25662568    m_wasLoadEventEmitted = false;
    25672569    m_outgoingReferrer = URL.url();
    2568 
    25692570    FrameView* view = cachedPage.view();
    25702571    if (view)
  • trunk/WebCore/platform/String.cpp

    r19451 r21682  
    511511}
    512512#endif
     513
     514#ifndef NDEBUG
     515void dump(const WebCore::String* s)
     516{
     517    if(s)
     518        printf("%s\n", s->ascii().data());
     519}
     520#endif
Note: See TracChangeset for help on using the changeset viewer.