Changeset 216911 in webkit
- Timestamp:
- May 16, 2017 12:09:56 AM (7 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r216908 r216911 1 2017-05-16 JF Bastien <jfbastien@apple.com> 2 3 WebAssembly: report Memory usage to GC 4 https://bugs.webkit.org/show_bug.cgi?id=170690 5 <rdar://problem/31965310> 6 7 Reviewed by Keith Miller. 8 9 * wasm/js/JSWebAssemblyMemory.cpp: 10 (JSC::JSWebAssemblyMemory::grow): 11 (JSC::JSWebAssemblyMemory::finishCreation): 12 (JSC::JSWebAssemblyMemory::visitChildren): 13 1 14 2017-05-16 JF Bastien <jfbastien@apple.com> 2 15 -
trunk/Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp
r215340 r216911 1 1 /* 2 * Copyright (C) 2016 Apple Inc. All rights reserved.2 * Copyright (C) 2016-2017 Apple Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 118 118 119 119 memory().check(); 120 // FIXME Should we report extra memory to the GC on allocation / grow / visit? https://bugs.webkit.org/show_bug.cgi?id=170690 120 121 vm.heap.reportExtraMemoryAllocated(Wasm::PageCount(delta).bytes()); 121 122 return oldPageCount; 122 123 } … … 126 127 Base::finishCreation(vm); 127 128 ASSERT(inherits(vm, info())); 128 // FIXME Should we report extra memory to the GC on allocation / grow / visit? https://bugs.webkit.org/show_bug.cgi?id=170690129 heap()->reportExtraMemoryAllocated(memory().size()); 129 130 vm.heap.reportWebAssemblyFastMemoriesAllocated(1); 130 131 } … … 145 146 Base::visitChildren(thisObject, visitor); 146 147 visitor.append(thisObject->m_bufferWrapper); 147 // FIXME Should we report extra memory to the GC on allocation / grow / visit? https://bugs.webkit.org/show_bug.cgi?id=170690148 visitor.reportExtraMemoryVisited(thisObject->memory().size()); 148 149 } 149 150
Note: See TracChangeset
for help on using the changeset viewer.