Changeset 217107 in webkit

Timestamp:

May 19, 2017 2:19:01 AM (7 years ago)

Author:

rniwa@webkit.org

Message:

Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
​https://bugs.webkit.org/show_bug.cgi?id=172348

Reviewed by Antti Koivisto.

The bug was caused by the in-memory store class using the milisecond precision timestamp as an ID.
Because we inserts 50 items all at once, this can result in multiple data items sharing a single ID.

Fixed the bug by using a mononotically increasing ID instead.

• Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:

(Store.prototype.save):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js (modified) (2 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-05-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
+        https://bugs.webkit.org/show_bug.cgi?id=172348
+
+        Reviewed by Antti Koivisto.
+
+        The bug was caused by the in-memory store class using the milisecond precision timestamp as an ID.
+        Because we inserts 50 items all at once, this can result in multiple data items sharing a single ID.
+
+        Fixed the bug by using a mononotically increasing ID instead.
+
+        * Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
+        (Store.prototype.save):
+
 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js

@@ -4 +4 @@
 
     var MemoryStorage = {};
+    var id = 1;
+
     /**
      * Creates a new client side storage object and will create an empty
@@ -97 +99 @@
         } else {
             // Generate an ID
-            updateData.id = new Date().getTime();
+            updateData.id = id++;
 
             todos.push(updateData);