Changeset 217130 in webkit


Ignore:
Timestamp:
May 19, 2017 9:23:15 AM (7 years ago)
Author:
Jonathan Bedard
Message:

webkitpy: Layout tests which have no output will succeed
https://bugs.webkit.org/show_bug.cgi?id=172322
<rdar://problem/32258350>

Reviewed by David Kilzer.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type): FailureNotTested means that the test could not be loaded. This
is classified as a MISSING failure.
(FailureNotTested): Added.
(FailureNotTested.message):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r217124 r217130  
     12017-05-19  Jonathan Bedard  <jbedard@apple.com>
     2
     3        webkitpy: Layout tests which have no output will succeed
     4        https://bugs.webkit.org/show_bug.cgi?id=172322
     5        <rdar://problem/32258350>
     6
     7        Reviewed by David Kilzer.
     8
     9        * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
     10        (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
     11        * Scripts/webkitpy/layout_tests/models/test_failures.py:
     12        (determine_result_type): FailureNotTested means that the test could not be loaded. This
     13        is classified as a MISSING failure.
     14        (FailureNotTested): Added.
     15        (FailureNotTested.message):
     16
    1172017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
    218
  • trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

    r213918 r217130  
    241241        elif actual_text and not expected_text:
    242242            failures.append(test_failures.FailureMissingResult())
     243        elif not actual_text and expected_text:
     244            failures.append(test_failures.FailureNotTested())
    243245        return failures
    244246
  • trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

    r202362 r217130  
    6363          FailureMissingImage in failure_types or
    6464          FailureMissingImageHash in failure_types or
    65           FailureMissingAudio in failure_types):
     65          FailureMissingAudio in failure_types or
     66          FailureNotTested in failure_types):
    6667        return test_expectations.MISSING
    6768    else:
     
    165166
    166167
     168class FailureNotTested(FailureText):
     169    def message(self):
     170        return 'test was not run'
     171
    167172class FailureTextMismatch(FailureText):
    168173    def message(self):
     
    266271# Convenient collection of all failure classes for anything that might
    267272# need to enumerate over them all.
    268 ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult,
     273ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, FailureNotTested,
    269274                       FailureTextMismatch, FailureMissingImageHash,
    270275                       FailureMissingImage, FailureImageHashMismatch,
Note: See TracChangeset for help on using the changeset viewer.