Changeset 217130 in webkit
- Timestamp:
- May 19, 2017 9:23:15 AM (7 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r217124 r217130 1 2017-05-19 Jonathan Bedard <jbedard@apple.com> 2 3 webkitpy: Layout tests which have no output will succeed 4 https://bugs.webkit.org/show_bug.cgi?id=172322 5 <rdar://problem/32258350> 6 7 Reviewed by David Kilzer. 8 9 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: 10 (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output. 11 * Scripts/webkitpy/layout_tests/models/test_failures.py: 12 (determine_result_type): FailureNotTested means that the test could not be loaded. This 13 is classified as a MISSING failure. 14 (FailureNotTested): Added. 15 (FailureNotTested.message): 16 1 17 2017-05-19 Yusuke Suzuki <utatane.tea@gmail.com> 2 18 -
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
r213918 r217130 241 241 elif actual_text and not expected_text: 242 242 failures.append(test_failures.FailureMissingResult()) 243 elif not actual_text and expected_text: 244 failures.append(test_failures.FailureNotTested()) 243 245 return failures 244 246 -
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
r202362 r217130 63 63 FailureMissingImage in failure_types or 64 64 FailureMissingImageHash in failure_types or 65 FailureMissingAudio in failure_types): 65 FailureMissingAudio in failure_types or 66 FailureNotTested in failure_types): 66 67 return test_expectations.MISSING 67 68 else: … … 165 166 166 167 168 class FailureNotTested(FailureText): 169 def message(self): 170 return 'test was not run' 171 167 172 class FailureTextMismatch(FailureText): 168 173 def message(self): … … 266 271 # Convenient collection of all failure classes for anything that might 267 272 # need to enumerate over them all. 268 ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, 273 ALL_FAILURE_CLASSES = (FailureTimeout, FailureCrash, FailureMissingResult, FailureNotTested, 269 274 FailureTextMismatch, FailureMissingImageHash, 270 275 FailureMissingImage, FailureImageHashMismatch,
Note: See TracChangeset
for help on using the changeset viewer.