Changeset 217180 in webkit

Timestamp:

May 19, 2017 6:59:16 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Add RTCPeerConnection connection state change logging
​https://bugs.webkit.org/show_bug.cgi?id=172314

Patch by Youenn Fablet <​youenn@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

No change of behavior.
Adding some release logging of connection state changes.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::rtcIceGatheringStateToString):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::rtcIceConnectionStateToString):
(WebCore::RTCPeerConnection::updateIceConnectionState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/RTCPeerConnection.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-19  Youenn Fablet  <youenn@apple.com>
+
+        Add RTCPeerConnection connection state change logging
+        https://bugs.webkit.org/show_bug.cgi?id=172314
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior.
+        Adding some release logging of connection state changes.
+
+        * Modules/mediastream/RTCPeerConnection.cpp:
+        (WebCore::rtcIceGatheringStateToString):
+        (WebCore::RTCPeerConnection::updateIceGatheringState):
+        (WebCore::rtcIceConnectionStateToString):
+        (WebCore::RTCPeerConnection::updateIceConnectionState):
+
 2017-05-19  Jeremy Jones  <jeremyj@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

@@ -445 +445 @@
 }
 
+#if !RELEASE_LOG_DISABLED
+static inline const char* rtcIceGatheringStateToString(RTCIceGatheringState newState)
+{
+    switch (newState) {
+    case RTCIceGatheringState::New:
+        return "new";
+    case RTCIceGatheringState::Gathering:
+        return "gathering";
+    case RTCIceGatheringState::Complete:
+        return "complete";
+    }
+}
+#endif
+
 void RTCPeerConnection::updateIceGatheringState(RTCIceGatheringState newState)
 {
+    RELEASE_LOG(WebRTC, "New ICE gathering state: %s\n", rtcIceGatheringStateToString(newState));
+
     scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
         if (protectedThis->isClosed() || protectedThis->m_iceGatheringState == newState)
@@ -457 +473 @@
 }
 
+#if !RELEASE_LOG_DISABLED
+static inline const char* rtcIceConnectionStateToString(RTCIceConnectionState newState)
+{
+    switch (newState) {
+    case RTCIceConnectionState::New:
+        return "new";
+    case RTCIceConnectionState::Checking:
+        return "checking";
+    case RTCIceConnectionState::Connected:
+        return "connected";
+    case RTCIceConnectionState::Completed:
+        return "completed";
+    case RTCIceConnectionState::Failed:
+        return "failed";
+    case RTCIceConnectionState::Disconnected:
+        return "disconnected";
+    case RTCIceConnectionState::Closed:
+        return "closed";
+    }
+}
+#endif
+
 void RTCPeerConnection::updateIceConnectionState(RTCIceConnectionState newState)
 {
+    RELEASE_LOG(WebRTC, "New ICE connection state: %s\n", rtcIceConnectionStateToString(newState));
+
     scriptExecutionContext()->postTask([protectedThis = makeRef(*this), newState](ScriptExecutionContext&) {
         if (protectedThis->isClosed() || protectedThis->m_iceConnectionState == newState)