Changeset 217181 in webkit

Timestamp:

May 19, 2017 7:30:27 PM (7 years ago)

Author:

Chris Dumez

Message:

Consider not exposing webkitURL in workers
​https://bugs.webkit.org/show_bug.cgi?id=172166

Reviewed by Geoffrey Garen.

Source/WebCore:

Drop webkitURL alias for URL in workers, to match other browsers. The risk should
be low given that this only impacts workers, we expose URL to workers and Blink
does not have this alias. We still support the webkitURL alias for URL on Window.

No new tests, rebaselined existing test.

• workers/WorkerGlobalScope.idl:

LayoutTests:

Rebaseline existing test to reflect behavior change.

• js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/workers/WorkerGlobalScope.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-05-19  Chris Dumez  <cdumez@apple.com>
+
+        Consider not exposing webkitURL in workers
+        https://bugs.webkit.org/show_bug.cgi?id=172166
+
+        Reviewed by Geoffrey Garen.
+
+        Rebaseline existing test to reflect behavior change.
+
+        * js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+
 2017-05-19  Jeremy Jones  <jeremyj@apple.com>
 

trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

@@ -390 +390 @@
 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'XMLHttpRequestEventTarget').enumerable is false
 PASS [Worker] Object.getOwnPropertyDescriptor(global, 'XMLHttpRequestEventTarget').configurable is true
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').value is webkitURL
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').hasOwnProperty('get') is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').hasOwnProperty('set') is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').enumerable is false
-PASS [Worker] Object.getOwnPropertyDescriptor(global, 'webkitURL').configurable is true
 PASS successfullyParsed is true
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-05-19  Chris Dumez  <cdumez@apple.com>
+
+        Consider not exposing webkitURL in workers
+        https://bugs.webkit.org/show_bug.cgi?id=172166
+
+        Reviewed by Geoffrey Garen.
+
+        Drop webkitURL alias for URL in workers, to match other browsers. The risk should
+        be low given that this only impacts workers, we expose URL to workers and Blink
+        does not have this alias. We still support the webkitURL alias for URL on Window.
+
+        No new tests, rebaselined existing test.
+
+        * workers/WorkerGlobalScope.idl:
+
 2017-05-19  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/workers/WorkerGlobalScope.idl

@@ -46 +46 @@
     // Additional constructors
 
-    attribute DOMURLConstructor webkitURL; // FIXME: deprecate this.
-
     // FIXME: Automatically generate these once we can drop the IndexedDBWorkers runtime flag.
     [Conditional=INDEXED_DATABASE_IN_WORKERS, EnabledAtRuntime=IndexedDBWorkers] attribute IDBCursorConstructor IDBCursor;