Changeset 217230 in webkit

Timestamp:

May 22, 2017 11:29:05 AM (7 years ago)

Author:

Dewei Zhu

Message:

Fix the bug that sometimes analysis task results pane is missing.
​https://bugs.webkit.org/show_bug.cgi?id=172404

Reviewed by Ryosuke Niwa.

AnalysisTaskPage._didFetchTask and AnalaysisTaskPage._fetchRelatedInfoForTaskId should be called in order.
The race between those two functions causes the analysis task results pane sometimes missing.

• public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype.render): Fix the bug in r217173 that commitSet can be undefined.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype.updateFromSerializedState): Use arrow function to get rid of self variable.
Use const instead of var for constant variable. And call _didFetchTask before calling _fetchRelatedInfoForTaskId.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus):
(AnalysisTaskPage.cssTemplate):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v3/components/analysis-results-viewer.js (modified) (1 diff)
• public/v3/pages/analysis-task-page.js (modified) (4 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2017-05-22  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Fix the bug that sometimes analysis task results pane is missing.
+        https://bugs.webkit.org/show_bug.cgi?id=172404
+
+        Reviewed by Ryosuke Niwa.
+
+        AnalysisTaskPage._didFetchTask and AnalaysisTaskPage._fetchRelatedInfoForTaskId should be called in order.
+        The race between those two functions causes the analysis task results pane sometimes missing.
+
+        * public/v3/components/analysis-results-viewer.js:
+        (AnalysisResultsViewer.prototype.render): Fix the bug in r217173 that commitSet can be undefined.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype.updateFromSerializedState): Use arrow function to get rid of self variable.
+        Use `const` instead of var for constant variable. And call _didFetchTask before calling _fetchRelatedInfoForTaskId.
+        (AnalysisTaskPage.prototype._renderTaskNameAndStatus):
+        (AnalysisTaskPage.cssTemplate):
+
 2017-05-19  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js

@@ -63 +63 @@
         for (const label of this._rangeSelectorLabels) {
             const commitSet = this._selectedRange[label];
+            if (!commitSet)
+                continue;
             const list = this._selectorRadioButtonList[label] || [];
             for (const item of list) {

trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

@@ -223 +223 @@
         super.render();
     }
-    
+
     static htmlTemplate()
     {
@@ -466 +466 @@
     updateFromSerializedState(state)
     {
-        var self = this;
         if (state.remainingRoute) {
-            var taskId = parseInt(state.remainingRoute);
-            AnalysisTask.fetchById(taskId).then(this._didFetchTask.bind(this), function (error) {
-                self._errorMessage = `Failed to fetch the analysis task ${state.remainingRoute}: ${error}`;
-                self.enqueueToRender();
+            const taskId = parseInt(state.remainingRoute);
+            AnalysisTask.fetchById(taskId).then(this._didFetchTask.bind(this)).then(() => {
+                this._fetchRelatedInfoForTaskId(taskId);
+            }, (error) => {
+                this._errorMessage = `Failed to fetch the analysis task ${state.remainingRoute}: ${error}`;
+                this.enqueueToRender();
             });
-            this._fetchRelatedInfoForTaskId(taskId);
         } else if (state.buildRequest) {
-            var buildRequestId = parseInt(state.buildRequest);
-            AnalysisTask.fetchByBuildRequestId(buildRequestId).then(this._didFetchTask.bind(this)).then(function (task) {
-                self._fetchRelatedInfoForTaskId(task.id());
-            }, function (error) {
-                self._errorMessage = `Failed to fetch the analysis task for the build request ${buildRequestId}: ${error}`;
-                self.enqueueToRender();
+            const buildRequestId = parseInt(state.buildRequest);
+            AnalysisTask.fetchByBuildRequestId(buildRequestId).then(this._didFetchTask.bind(this)).then((task) => {
+                this._fetchRelatedInfoForTaskId(task.id());
+            }, (error) => {
+                this._errorMessage = `Failed to fetch the analysis task for the build request ${buildRequestId}: ${error}`;
+                this.enqueueToRender();
             });
         }
@@ -648 +648 @@
             const metric = task.metric();
             const subtitle = `${metric.fullName()} on ${platform.label()}`;
-            this.renderReplace(this.content('platform-metric-names'), 
+            this.renderReplace(this.content('platform-metric-names'),
                 link(subtitle, this.router().url('charts', ChartsPage.createStateForAnalysisTask(task))));
         }
@@ -958 +958 @@
                 border-bottom: solid 1px #ccc;
             }
-            
+
             #results-pane {
                 margin-top: 1rem;