Changeset 21739 in webkit

Timestamp:

May 24, 2007 4:51:23 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider

• fast/forms/slider-thumb-shared-style-expected.checksum: Added.
• fast/forms/slider-thumb-shared-style-expected.png: Added.
• fast/forms/slider-thumb-shared-style-expected.txt: Added.
• fast/forms/slider-thumb-shared-style.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13800 REGRESSION: Moving a slider moves another unrelated slider

Test: fast/forms/slider-thumb-shared-style.html

RenderSlider mutates the thumb's style, therefore it must not be shared
with another slider's thumb, a situation that could occur if the sliders
themselves shared style.

• rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Always use a private copy for the thumb style.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/slider-thumb-shared-style-expected.checksum (added)
• LayoutTests/fast/forms/slider-thumb-shared-style-expected.png (added)
• LayoutTests/fast/forms/slider-thumb-shared-style-expected.txt (added)
• LayoutTests/fast/forms/slider-thumb-shared-style.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderSlider.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-24  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=13800
+          REGRESSION: Moving a slider moves another unrelated slider
+
+        * fast/forms/slider-thumb-shared-style-expected.checksum: Added.
+        * fast/forms/slider-thumb-shared-style-expected.png: Added.
+        * fast/forms/slider-thumb-shared-style-expected.txt: Added.
+        * fast/forms/slider-thumb-shared-style.html: Added.
+
 2007-05-24  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-05-24  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13800
+          REGRESSION: Moving a slider moves another unrelated slider
+
+        Test: fast/forms/slider-thumb-shared-style.html
+
+        RenderSlider mutates the thumb's style, therefore it must not be shared
+        with another slider's thumb, a situation that could occur if the sliders
+        themselves shared style.
+
+        * rendering/RenderSlider.cpp:
+        (WebCore::RenderSlider::createThumbStyle): Always use a private copy for
+        the thumb style.
+
 2007-05-24  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/rendering/RenderSlider.cpp

@@ -177 +177 @@
 RenderStyle* RenderSlider::createThumbStyle(RenderStyle* parentStyle)
 {
-    RenderStyle* style = getPseudoStyle(RenderStyle::SLIDER_THUMB);
-    if (!style)
+    RenderStyle* style;
+
+    RenderStyle* pseudoStyle = getPseudoStyle(RenderStyle::SLIDER_THUMB);
+    if (pseudoStyle)
+        // We may be sharing style with another slider, but we must not share the thumb style.
+        style = new (renderArena()) RenderStyle(pseudoStyle);
+    else
         style = new (renderArena()) RenderStyle();