Changeset 21761 in webkit

Timestamp:

May 25, 2007 10:26:32 AM (17 years ago)

Author:

weinig

Message:

JavaScriptCore:

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
• Create the error node based on the actual node, not the node inside parenthesis
• Fix applies to postfix, prefix and typeof operators
• Produces run-time ReferenceError like other non-lvalue assignments etc.

• kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node, not the based on the node returned by "nodeInsideAllParens()". Same for TypeOfValueNode.

LayoutTests:

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function doesn't compile with "++(x,y)")
• Contains tests for grouping expression that is inside typeof or prefix/postfix expression

• fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
• fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
• fast/js/toString-prefix-postfix-preserve-parens.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/grammar.y (modified) (3 diffs)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/resources/toString-prefix-postfix-preserve-parens.js (added)
• LayoutTests/fast/js/toString-prefix-postfix-preserve-parens-expected.txt (added)
• LayoutTests/fast/js/toString-prefix-postfix-preserve-parens.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-05-25  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function
+          doesn't compile with "++(x,y)")
+        - Create the error node based on the actual node, not the node inside
+          parenthesis
+        - Fix applies to postfix, prefix and typeof operators
+        - Produces run-time ReferenceError like other non-lvalue assignments etc.
+
+        * kjs/grammar.y: Create {Prefix,Postfix}ErrorNode based on the actual node,
+        not the based on the node returned by "nodeInsideAllParens()". Same for
+        TypeOfValueNode.
+
 2007-05-25  Simon Hausmann  <hausmann@kde.org>
 

trunk/JavaScriptCore/kjs/grammar.y

@@ -896 +896 @@
 
     if (!n->isLocation())
-        return new PrefixErrorNode(n, op);
+        return new PrefixErrorNode(expr, op);
     
     if (n->isResolveNode()) {
@@ -916 +916 @@
 
     if (!n->isLocation())
-        return new PostfixErrorNode(n, op);
+        return new PostfixErrorNode(expr, op);
     
     if (n->isResolveNode()) {
@@ -964 +964 @@
         return new TypeOfResolveNode(resolve->identifier());
     } else
-        return new TypeOfValueNode(n);
+        return new TypeOfValueNode(expr);
 }
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-25  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - http://bugs.webkit.org/show_bug.cgi?id=13623 (Decompilation of function
+          doesn't compile with "++(x,y)")
+        - Contains tests for grouping expression that is inside typeof or prefix/postfix
+          expression
+
+        * fast/js/resources/toString-prefix-postfix-preserve-parens.js: Added.
+        * fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
+        * fast/js/toString-prefix-postfix-preserve-parens.html: Added.
+
 2007-05-25  Mitz Pettel  <mitz@webkit.org>