Changeset 217946 in webkit

Timestamp:

Jun 8, 2017 1:39:00 PM (7 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Run sample/spindump on iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=171881
<rdar://problem/32084602>

Reviewed by Daniel Bates.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
requires sudo to run spindump.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.look_for_new_samples): Deleted.
(IOSDevicePort.sample_process): Deleted.

• Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest): iOS devices use 'ios' and their os_name.
(IOSDeviceTest.test_spindump):
(IOSDeviceTest.test_sample_process):
(IOSDeviceTest.test_sample_process_exception):

• Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)
• Scripts/webkitpy/port/ios_device.py (modified) (1 diff)
• Scripts/webkitpy/port/ios_device_unittest.py (modified) (3 diffs)
• Scripts/webkitpy/port/ios_simulator_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-06-08  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Run sample/spindump on iOS devices
+        https://bugs.webkit.org/show_bug.cgi?id=171881
+        <rdar://problem/32084602>
+
+        Reviewed by Daniel Bates.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
+        requires sudo to run spindump.
+        * Scripts/webkitpy/port/ios_device.py:
+        (IOSDevicePort.look_for_new_samples): Deleted.
+        (IOSDevicePort.sample_process): Deleted.
+        * Scripts/webkitpy/port/ios_device_unittest.py:
+        (IOSDeviceTest): iOS devices use 'ios' and their os_name.
+        (IOSDeviceTest.test_spindump):
+        (IOSDeviceTest.test_sample_process):
+        (IOSDeviceTest.test_sample_process_exception):
+        * Scripts/webkitpy/port/ios_simulator_unittest.py:
+        (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
+
 2017-06-08  Keith Miller  <keith_miller@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -155 +155 @@
         host = target_host or self.host
         tempdir = host.filesystem.mkdtemp()
-        exit_status = host.executive.run_command([
-            "/usr/bin/sudo",
-            "-n",
-            "/usr/sbin/spindump",
+        command = [
+            '/usr/sbin/spindump',
             pid,
             10,
             10,
-            "-file",
+            '-file',
             DarwinPort.spindump_file_path(host, name, pid, str(tempdir)),
-        ], return_exit_code=True)
+        ]
+        if self.host.platform.is_mac():
+            command = ['/usr/bin/sudo', '-n'] + command
+        exit_status = host.executive.run_command(command, return_exit_code=True)
         if exit_status:
             try:
                 host.executive.run_command([
-                    "/usr/bin/sample",
+                    '/usr/bin/sample',
                     pid,
                     10,
                     10,
-                    "-file",
+                    '-file',
                     DarwinPort.sample_file_path(host, name, pid, str(tempdir)),
                 ])

trunk/Tools/Scripts/webkitpy/port/ios_device.py

@@ -96 +96 @@
         pass
 
-    def look_for_new_samples(self, unresponsive_processes, start_time):
-        return {}
-
-    def sample_process(self, name, pid, target_host=None):
-        pass
-
     # Despite their names, these flags do not actually get passed all the way down to webkit-build.
     def _build_driver_flags(self):

trunk/Tools/Scripts/webkitpy/port/ios_device_unittest.py

@@ -23 +23 @@
 import time
 
+from webkitpy.common.system.outputcapture import OutputCapture
+from webkitpy.common.system.executive_mock import MockExecutive2, ScriptError
 from webkitpy.port.ios_device import IOSDevicePort
 from webkitpy.port import ios_testcase
@@ -28 +30 @@
 
 class IOSDeviceTest(ios_testcase.IOSTest):
-    os_name = 'ios-device'
+    os_name = 'ios'
     os_version = ''
     port_name = 'ios-device'
@@ -45 +47 @@
             port.path_to_crash_logs()
 
+    def test_spindump(self):
+        def logging_run_command(args):
+            print args
+
+        port = self.make_port()
+        port.host.filesystem.files['/__im_tmp/tmp_0_/test-42-spindump.txt'] = 'Spindump file'
+        port.host.executive = MockExecutive2(run_command_fn=logging_run_command)
+        expected_stdout = "['/usr/sbin/spindump', 42, 10, 10, '-file', '/__im_tmp/tmp_0_/test-42-spindump.txt']\n"
+        OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42], expected_stdout=expected_stdout)
+        self.assertEqual(port.host.filesystem.files['/mock-build/layout-test-results/test-42-spindump.txt'], 'Spindump file')
+        self.assertIsNone(port.host.filesystem.files['/__im_tmp/tmp_0_/test-42-spindump.txt'])
+
+    def test_sample_process(self):
+        def logging_run_command(args):
+            if args[0] == '/usr/sbin/spindump':
+                return 1
+            print args
+            return 0
+
+        port = self.make_port()
+        port.host.filesystem.files['/__im_tmp/tmp_0_/test-42-sample.txt'] = 'Sample file'
+        port.host.executive = MockExecutive2(run_command_fn=logging_run_command)
+        expected_stdout = "['/usr/bin/sample', 42, 10, 10, '-file', '/__im_tmp/tmp_0_/test-42-sample.txt']\n"
+        OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42], expected_stdout=expected_stdout)
+        self.assertEqual(port.host.filesystem.files['/mock-build/layout-test-results/test-42-sample.txt'], 'Sample file')
+        self.assertIsNone(port.host.filesystem.files['/__im_tmp/tmp_0_/test-42-sample.txt'])
+
+    def test_sample_process_exception(self):
+        def throwing_run_command(args):
+            if args[0] == '/usr/sbin/spindump':
+                return 1
+            raise ScriptError('MOCK script error')
+
+        port = self.make_port()
+        port.host.executive = MockExecutive2(run_command_fn=throwing_run_command)
+        OutputCapture().assert_outputs(self, port.sample_process, args=['test', 42])
+
     def test_get_crash_log(self):
         port = self.make_port(port_name=self.port_name)
         with self.assertRaises(RuntimeError):
             port._get_crash_log('DumpRenderTree', 1234, None, None, time.time(), wait_for_log=False)
-
-    # FIXME: Update tests when <rdar://problem/30497991> is completed.
-    def test_spindump(self):
-        pass
-
-    def test_sample_process(self):
-        pass
-
-    def test_sample_process_exception(self):
-        pass

trunk/Tools/Scripts/webkitpy/port/ios_simulator_unittest.py

@@ -31 +31 @@
 
 class IOSSimulatorTest(ios_testcase.IOSTest):
-    os_name = 'ios-simulator'
+    # FIXME: https://bugs.webkit.org/show_bug.cgi?id=173107
+    os_name = 'mac'
     os_version = ''
     port_name = 'ios-simulator'