Changeset 218202 in webkit
- Timestamp:
- Jun 13, 2017 2:03:52 PM (7 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r218179 r218202 1 2017-06-13 Nikita Vasilyev <nvasilyev@apple.com> 2 3 Web Inspector: Don't use -webkit-user-modify CSS property 4 https://bugs.webkit.org/show_bug.cgi?id=173232 5 6 Reviewed by Devin Rousso. 7 8 Replace -webkit-user-modify CSS property with contentEditable HTML attribute. 9 10 * UserInterface/Views/Editing.css: 11 (.editing): 12 * UserInterface/Views/EditingSupport.js: 13 (cleanUpAfterEditing): 14 * UserInterface/Views/VisualStyleSelectorTreeItem.css: 15 (.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title): 16 * UserInterface/Views/VisualStyleSelectorTreeItem.js: 17 (WebInspector.VisualStyleSelectorTreeItem.prototype.ondeselect): 18 (WebInspector.VisualStyleSelectorTreeItem.prototype._handleMainTitleMouseDown): 19 (WebInspector.VisualStyleSelectorTreeItem.prototype._commitSelector): 20 1 21 2017-06-13 Sam Weinig <sam@webkit.org> 2 22 -
trunk/Source/WebInspectorUI/UserInterface/Views/Editing.css
r195730 r218202 29 29 outline: 1px solid hsl(0, 0%, 65%) !important; 30 30 background-color: white; 31 -webkit-user-modify: read-write-plaintext-only;32 31 text-overflow: clip !important; 33 32 padding-left: 2px; -
trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js
r196271 r218202 123 123 124 124 element.classList.add("editing"); 125 element.contentEditable = "plaintext-only"; 125 126 126 127 var oldSpellCheck = element.hasAttribute("spellcheck") ? element.spellcheck : undefined; … … 150 151 151 152 this.classList.remove("editing"); 153 this.contentEditable = false; 154 152 155 this.scrollTop = 0; 153 156 this.scrollLeft = 0; -
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.css
r197119 r218202 120 120 cursor: text; 121 121 -webkit-user-select: text; 122 -webkit-user-modify: read-write-plaintext-only;123 122 } 124 123 -
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js
r215630 r218202 120 120 { 121 121 this._listItemNode.classList.remove("editable"); 122 this._mainTitleElement.contentEditable = false; 122 123 } 123 124 … … 240 241 241 242 this._listItemNode.classList.toggle("editable", this.selected); 243 this._mainTitleElement.contentEditable = this.selected ? "plaintext-only" : false; 242 244 } 243 245 … … 255 257 this._hideDOMNodeHighlight(); 256 258 this._listItemNode.classList.remove("editable"); 259 this._mainTitleElement.contentEditable = false; 257 260 this._updateTitleTooltip(); 258 261
Note: See TracChangeset
for help on using the changeset viewer.