Changeset 218382 in webkit

Timestamp:

Jun 15, 2017 11:03:18 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r218325): [GTK] Runtime critical warnings running layout tests that show a popup menu
​https://bugs.webkit.org/show_bug.cgi?id=173421

Reviewed by Carlos Alberto Lopez Perez.

In r218325 I forgot to create a WebKitPopupMenu or WebPopupMenuProxyGtk depending on whether the view is a
WebKitWebView or not.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createPopupMenuProxy):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/PageClientImpl.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r218325): [GTK] Runtime critical warnings running layout tests that show a popup menu
+        https://bugs.webkit.org/show_bug.cgi?id=173421
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        In r218325 I forgot to create a WebKitPopupMenu or WebPopupMenuProxyGtk depending on whether the view is a
+        WebKitWebView or not.
+
+        * UIProcess/API/gtk/PageClientImpl.cpp:
+        (WebKit::PageClientImpl::createPopupMenuProxy):
+
 2017-06-15  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp

@@ -207 +207 @@
 RefPtr<WebPopupMenuProxy> PageClientImpl::createPopupMenuProxy(WebPageProxy& page)
 {
-    return WebKitPopupMenu::create(m_viewWidget, page);
+    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
+        return WebKitPopupMenu::create(m_viewWidget, page);
+    return WebPopupMenuProxyGtk::create(m_viewWidget, page);
 }