Changeset 218787 in webkit


Ignore:
Timestamp:
Jun 24, 2017 8:14:40 AM (7 years ago)
Author:
Michael Catanzaro
Message:

[GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor
https://bugs.webkit.org/show_bug.cgi?id=173765

Reviewed by Carlos Garcia Campos.

Because the first parameter to this WebKitWebView constructor is itself a WebKitWebView,
the gi-scanner's heuristics decide that it's probably an object method rather than a
constructor, resulting in improper introspection generation. Annotate it with (constructor)
to override this behavior.

  • UIProcess/API/gtk/WebKitWebViewGtk.cpp:
  • UIProcess/API/wpe/WebKitWebViewWPE.cpp:
Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r218786 r218787  
     12017-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        [GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor
     4        https://bugs.webkit.org/show_bug.cgi?id=173765
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Because the first parameter to this WebKitWebView constructor is itself a WebKitWebView,
     9        the gi-scanner's heuristics decide that it's probably an object method rather than a
     10        constructor, resulting in improper introspection generation. Annotate it with (constructor)
     11        to override this behavior.
     12
     13        * UIProcess/API/gtk/WebKitWebViewGtk.cpp:
     14        * UIProcess/API/wpe/WebKitWebViewWPE.cpp:
     15
    1162017-06-24  Commit Queue  <commit-queue@webkit.org>
    217
  • trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGtk.cpp

    r218553 r218787  
    190190
    191191/**
    192  * webkit_web_view_new_with_related_view:
     192 * webkit_web_view_new_with_related_view: (constructor)
    193193 * @web_view: the related #WebKitWebView
    194194 *
  • trunk/Source/WebKit2/UIProcess/API/wpe/WebKitWebViewWPE.cpp

    r218553 r218787  
    7676
    7777/**
    78  * webkit_web_view_new_with_related_view:
     78 * webkit_web_view_new_with_related_view: (constructor)
    7979 * @web_view: the related #WebKitWebView
    8080 *
Note: See TracChangeset for help on using the changeset viewer.