Changeset 218878 in webkit
- Timestamp:
- Jun 28, 2017 9:32:49 AM (7 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r218877 r218878 1 2017-06-28 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 [GTK] Some web pages disappear immediately after rendering 4 https://bugs.webkit.org/show_bug.cgi?id=173768 5 6 Reviewed by Xabier Rodriguez-Calvar. 7 8 This is happening with websites having a "hidden" class in HTML tag when a media element is added. In the GTK+ 9 port the media controls CSS contains the following code: 10 11 .hidden { 12 display: none !important; 13 } 14 15 That causes the whole HTML document to become display: none. That's why we just render a white page, and also 16 the reason why it only happens with the GTK+ port and only with some specific websites. We should limit the 17 scope of the hidden class to the media control elements. 18 19 * css/mediaControlsGtk.css: 20 (audio::-webkit-media-controls-panel.hidden,): 21 (audio::-webkit-media-controls-panel div.mute-box.hidden,): 22 (audio::-webkit-media-controls-current-time-display.hidden,): 23 (audio::-webkit-media-controls-timeline.hidden,): 24 (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): 25 (audio::-webkit-media-controls-toggle-closed-captions-button.hidden,): 26 (video::-webkit-media-controls-closed-captions-container.hidden): 27 (audio::-webkit-media-controls-fullscreen-button.hidden,): 28 (.hidden): Deleted. 29 1 30 2017-06-28 Antoine Quint <graouts@apple.com> 2 31 -
trunk/Source/WebCore/css/mediaControlsGtk.css
r190205 r218878 28 28 /* These are based on the Chromium media controls */ 29 29 30 .hidden {31 display: none !important;32 }33 34 30 video::-webkit-media-controls-panel *:active, 35 31 video::-webkit-media-controls-panel *:focus, … … 42 38 audio::-webkit-media-controls-panel.down *:focus { 43 39 background-image: linear-gradient(rgba(255, 255, 255, .05), rgba(0, 0, 0, .05)) !important; 40 } 41 42 audio::-webkit-media-controls-panel.hidden, 43 video::-webkit-media-controls-panel.hidden { 44 display: none !important; 44 45 } 45 46 … … 121 122 } 122 123 124 audio::-webkit-media-controls-panel div.mute-box.hidden, 125 video::-webkit-media-controls-panel div.mute-box.hidden { 126 display: none !important; 127 } 128 123 129 audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button { 124 130 -webkit-appearance: media-mute-button; … … 177 183 text-shadow: none; 178 184 text-decoration: none; 185 } 186 187 audio::-webkit-media-controls-current-time-display.hidden, 188 video::-webkit-media-controls-current-time-display.hidden, 189 audio::-webkit-media-controls-time-remaining-display.hidden, 190 video::-webkit-media-controls-time-remaining-display.hidden { 191 display: none !important; 179 192 } 180 193 … … 195 208 audio::-webkit-media-controls-timeline[disabled], video::-webkit-media-controls-timeline[disabled] { 196 209 opacity: 0.3 !important; 210 } 211 212 audio::-webkit-media-controls-timeline.hidden, 213 video::-webkit-media-controls-timeline.hidden { 214 display: none !important; 197 215 } 198 216 … … 296 314 margin: 0 9px 0 -7px; 297 315 outline: none; 316 } 317 318 audio::-webkit-media-controls-toggle-closed-captions-button.hidden, 319 video::-webkit-media-controls-toggle-closed-captions-button.hidden { 320 display: none !important; 298 321 } 299 322 … … 323 346 } 324 347 348 video::-webkit-media-controls-closed-captions-container.hidden { 349 display: none !important; 350 } 351 325 352 video::-webkit-media-controls-closed-captions-container h3 { 326 353 padding-top: 8px; … … 369 396 outline: none; 370 397 } 398 399 audio::-webkit-media-controls-fullscreen-button.hidden, 400 video::-webkit-media-controls-fullscreen-button.hidden { 401 display: none !important; 402 }
Note: See TracChangeset
for help on using the changeset viewer.