Changeset 218990 in webkit


Ignore:
Timestamp:
Jun 30, 2017 12:34:01 AM (7 years ago)
Author:
dino@apple.com
Message:

REGRESSION (High Sierra): Gradient LayoutTests are failing
https://bugs.webkit.org/show_bug.cgi?id=174015
<rdar://problem/32332022>

Reviewed by Tim Horton.

Add the fudge factor to more of the gradient tests.

  • canvas/philip/tests.js:

(_assertPixelWithGradientNoise): Bump the factor up a bit.

  • canvas/philip/tests/2d.gradient.interpolate.multiple.html:
  • canvas/philip/tests/2d.gradient.interpolate.solid.html:
  • canvas/philip/tests/2d.gradient.radial.transform.1.html:
  • canvas/philip/tests/2d.gradient.radial.transform.2.html:
  • canvas/philip/tests/2d.gradient.radial.transform.3.html:
  • canvas/philip/tests/initial.reset.gradient.html:
Location:
trunk/LayoutTests
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r218986 r218990  
     12017-06-30  Dean Jackson  <dino@apple.com>
     2
     3        REGRESSION (High Sierra): Gradient LayoutTests are failing
     4        https://bugs.webkit.org/show_bug.cgi?id=174015
     5        <rdar://problem/32332022>
     6
     7        Reviewed by Tim Horton.
     8
     9        Add the fudge factor to more of the gradient tests.
     10
     11        * canvas/philip/tests.js:
     12        (_assertPixelWithGradientNoise): Bump the factor up a bit.
     13        * canvas/philip/tests/2d.gradient.interpolate.multiple.html:
     14        * canvas/philip/tests/2d.gradient.interpolate.solid.html:
     15        * canvas/philip/tests/2d.gradient.radial.transform.1.html:
     16        * canvas/philip/tests/2d.gradient.radial.transform.2.html:
     17        * canvas/philip/tests/2d.gradient.radial.transform.3.html:
     18        * canvas/philip/tests/initial.reset.gradient.html:
     19
    1202017-06-29  Chris Fleizach  <cfleizach@apple.com>
    221
  • trunk/LayoutTests/canvas/philip/tests.js

    r215291 r218990  
    9999function _assertPixelWithGradientNoise(canvas, x,y, r,g,b,a, pos, colour)
    100100{
    101     _assertPixelApprox(canvas, x, y, r, g, b, a, pos, colour, 3);
     101    _assertPixelApprox(canvas, x, y, r, g, b, a, pos, colour, 5);
    102102}
    103103
  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.multiple.html

    r71481 r218990  
    2020ctx.fillStyle = g;
    2121ctx.fillRect(0, 0, 200, 50);
    22 _assertPixelApprox(canvas, 50,25, 127,255,127,255, "50,25", "127,255,127,255", 3);
    23 _assertPixelApprox(canvas, 100,25, 0,255,255,255, "100,25", "0,255,255,255", 3);
    24 _assertPixelApprox(canvas, 150,25, 127,127,255,255, "150,25", "127,127,255,255", 3);
     22_assertPixelWithGradientNoise(canvas, 50,25, 127,255,127,255, "50,25", "127,255,127,255");
     23_assertPixelWithGradientNoise(canvas, 100,25, 0,255,255,255, "100,25", "0,255,255,255");
     24_assertPixelWithGradientNoise(canvas, 150,25, 127,127,255,255, "150,25", "127,127,255,255");
    2525
    2626
  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.solid.html

    r71481 r218990  
    1818ctx.fillStyle = g;
    1919ctx.fillRect(0, 0, 100, 50);
    20 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
     20_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
    2121
    2222
  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.1.html

    r71481 r218990  
    2222ctx.scale(10, 10);
    2323ctx.fillRect(-5, -2.5, 10, 5);
    24 _assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
    25 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
    26 _assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
     24_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
     25_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
     26_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
    2727
    2828
  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.2.html

    r71481 r218990  
    2323ctx.scale(10, 10);
    2424ctx.fillRect(-5, -2.5, 10, 5);
    25 _assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
    26 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
    27 _assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
     25_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
     26_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
     27_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
    2828
    2929
  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.radial.transform.3.html

    r71481 r218990  
    2323ctx.scale(10, 10);
    2424ctx.fillRect(-5, -2.5, 10, 5);
    25 _assertPixel(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
    26 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
    27 _assertPixel(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
     25_assertPixelWithGradientNoise(canvas, 25,25, 0,255,0,255, "25,25", "0,255,0,255");
     26_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
     27_assertPixelWithGradientNoise(canvas, 75,25, 0,255,0,255, "75,25", "0,255,0,255");
    2828
    2929
  • trunk/LayoutTests/canvas/philip/tests/initial.reset.gradient.html

    r71481 r218990  
    2222ctx.fillStyle = g;
    2323ctx.fillRect(0, 0, 100, 50);
    24 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
     24_assertPixelWithGradientNoise(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
    2525
    2626
Note: See TracChangeset for help on using the changeset viewer.