Changeset 219116 in webkit

Timestamp:

Jul 4, 2017 4:12:26 AM (7 years ago)

Author:

calvaris@igalia.com

Message:

[EME] Solve a couple of compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=174020

Reviewed by Michael Catanzaro.

• Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::isPersistentType): Added default return and
assertion.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::updateKeyStatuses): This warning was
already solved but I think adding an assertion for the default
case can help catch errors in the future.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/encryptedmedia/CDM.cpp (modified) (1 diff)
• Modules/encryptedmedia/MediaKeySession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [EME] Solve a couple of compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=174020
+
+        Reviewed by Michael Catanzaro.
+
+        * Modules/encryptedmedia/CDM.cpp:
+        (WebCore::CDM::isPersistentType): Added default return and
+        assertion.
+        * Modules/encryptedmedia/MediaKeySession.cpp:
+        (WebCore::MediaKeySession::updateKeyStatuses): This warning was
+        already solved but I think adding an assertion for the default
+        case can help catch errors in the future.
+
 2017-07-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp

@@ -182 +182 @@
         return true;
     }
+
+    ASSERT_NOT_REACHED();
+    return false;
 }
 

trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp

@@ -633 +633 @@
             return MediaKeyStatus::StatusPending;
         case CDMInstance::KeyStatus::InternalError:
-            break;
+            return MediaKeyStatus::InternalError;
         };
+
+        ASSERT_NOT_REACHED();
         return MediaKeyStatus::InternalError;
     };