Changeset 219173 in webkit

Timestamp:

Jul 5, 2017 5:26:31 PM (7 years ago)

Author:

mmaxfield@apple.com

Message:

CSSFontStyleValue::isItalic seems a bit bogus.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Reviewed by Tim Horton.

Source/WebCore:

Simple typo.

Test: editing/execCommand/italicizeByCharacter-normal.html

• css/CSSFontStyleValue.h:

LayoutTests:

• editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
• editing/execCommand/italicizeByCharacter-normal.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/execCommand/italicizeByCharacter-normal-expected.txt (added)
• LayoutTests/editing/execCommand/italicizeByCharacter-normal.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSFontStyleValue.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        CSSFontStyleValue::isItalic seems a bit bogus.
+        https://bugs.webkit.org/show_bug.cgi?id=174149
+
+        Reviewed by Tim Horton.
+
+        * editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
+        * editing/execCommand/italicizeByCharacter-normal.html: Added.
+
 2017-07-05  Matt Lewis  <jlewis3@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        CSSFontStyleValue::isItalic seems a bit bogus.
+        https://bugs.webkit.org/show_bug.cgi?id=174149
+
+        Reviewed by Tim Horton.
+
+        Simple typo.
+
+        Test: editing/execCommand/italicizeByCharacter-normal.html
+
+        * css/CSSFontStyleValue.h:
+
 2017-07-05  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/css/CSSFontStyleValue.h

@@ -51 +51 @@
         if (!obliqueValue) {
             auto valueID = fontStyleValue->valueID();
-            return valueID == CSSValueItalic || CSSValueOblique;
+            return valueID == CSSValueItalic || valueID == CSSValueOblique;
         }
         return obliqueValue->value<float>(CSSPrimitiveValue::CSS_DEG) >= static_cast<float>(italicValue());