Changeset 219230 in webkit

Timestamp:

Jul 6, 2017 6:56:42 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Rendering of WebRTC audio in AudioSampleDataSource may trigger crackles
​https://bugs.webkit.org/show_bug.cgi?id=174223

Patch by Youenn Fablet <​youenn@apple.com> on 2017-07-06
Reviewed by Eric Carlson.

We try reading too quickly and need to back off a little bit if we do not enough data.
This only affects real audio and not web audio, hence validated through manual testing only.

• platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/mac/AudioSampleDataSource.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-06  Youenn Fablet  <youenn@apple.com>
+
+        Rendering of WebRTC audio in AudioSampleDataSource may trigger crackles
+        https://bugs.webkit.org/show_bug.cgi?id=174223
+
+        Reviewed by Eric Carlson.
+
+        We try reading too quickly and need to back off a little bit if we do not enough data.
+        This only affects real audio and not web audio, hence validated through manual testing only.
+
+        * platform/audio/mac/AudioSampleDataSource.mm:
+        (WebCore::AudioSampleDataSource::pullSamplesInternal):
+
 2017-07-06  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm

@@ -270 +270 @@
 
         if (framesAvailable < sampleCount) {
-            int64_t delta = static_cast<int64_t>(timeStamp) - static_cast<int64_t>(endFrame);
-            if (delta > 0)
-                m_outputSampleOffset -= std::min<int64_t>(delta, sampleCount);
-        }
-
-        if (!framesAvailable) {
+            m_outputSampleOffset -= sampleCount - framesAvailable;
             AudioSampleBufferList::zeroABL(buffer, byteCount);
             return false;