Changeset 219234 in webkit

Timestamp:

Jul 6, 2017 8:37:17 PM (7 years ago)

Author:

yoav@yoav.ws

Message:

[preload] Avoid reflecting "video" and "audio" when they are not supported as value
​https://bugs.webkit.org/show_bug.cgi?id=174199

Reviewed by Youenn Fablet.

No new tests as video/audio is supported in tests. I tested this manually.

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as): Make sure "video" and "audio" will not be reflected when they are not supported.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLLinkElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-06  Yoav Weiss  <yoav@yoav.ws>
+
+        [preload] Avoid reflecting "video" and "audio" when they are not supported `as` value
+        https://bugs.webkit.org/show_bug.cgi?id=174199
+
+        Reviewed by Youenn Fablet.
+
+        No new tests as video/audio is supported in tests. I tested this manually.
+
+        * html/HTMLLinkElement.cpp:
+        (WebCore::HTMLLinkElement::as): Make sure "video" and "audio" will not be reflected when they are not supported.
+
 2017-07-06  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLLinkElement.cpp

@@ -49 +49 @@
 #include "MouseEvent.h"
 #include "RenderStyle.h"
+#include "RuntimeEnabledFeatures.h"
 #include "SecurityOrigin.h"
 #include "Settings.h"
@@ -232 +233 @@
         || equalLettersIgnoringASCIICase(as, "script")
         || equalLettersIgnoringASCIICase(as, "style")
-        || equalLettersIgnoringASCIICase(as, "video")
-        || equalLettersIgnoringASCIICase(as, "audio")
+        || (RuntimeEnabledFeatures::sharedFeatures().mediaPreloadingEnabled()
+            && (equalLettersIgnoringASCIICase(as, "video")
+                || equalLettersIgnoringASCIICase(as, "audio")))
 #if ENABLE(VIDEO_TRACK)
         || equalLettersIgnoringASCIICase(as, "track")