Changeset 219251 in webkit


Ignore:
Timestamp:
Jul 7, 2017 3:25:00 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Speedometer 2.0: Fix vanilla JS example
​https://bugs.webkit.org/show_bug.cgi?id=174246

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-07-07
Reviewed by Ryosuke Niwa.

Previously, all TODO items were assigned an ID of null. This patch
fixes that bug. Manually deleting items now works again.

  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Made title consistent.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Fixed bug with deleting items.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added docs.
Location:
trunk/PerformanceTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/PerformanceTests/ChangeLog

    r219223 r219251  
     12017-07-07  Mathias Bynens  <mathias@qiwi.be>
     2
     3        Speedometer 2.0: Fix vanilla JS example
     4        https://bugs.webkit.org/show_bug.cgi?id=174246
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Previously, all TODO items were assigned an ID of `null`. This patch
     9        fixes that bug. Manually deleting items now works again.
     10
     11        * Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Made title consistent.
     12        * Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Fixed bug with deleting items.
     13        * Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added docs.
     14
    1152017-07-06  Myles C. Maxfield  <mmaxfield@apple.com>
    216

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html

    r216719 r219251  
    33    <head>
    44        <meta charset="utf-8">
    5         <title>VanillaJS • TodoMVC</title>
     5        <title>Vanilla JavaScript TodoMVC example</title>
    66        <link rel="stylesheet" href="node_modules/todomvc-common/base.css">
    77        <link rel="stylesheet" href="node_modules/todomvc-app-css/index.css">

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js

    r217107 r219251  
    44
    55    var MemoryStorage = {};
    6     var id = 1;
     6    var ID = 1;
    77
    88    /**
    … …  
    9999        } else {
    100100            // Generate an ID
    101             updateData.id = id++;
     101            updateData.id = ID++;
    102102
    103103            todos.push(updateData);

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md

    r156073 r219251  
    1 # Vanilla JavaScript TodoMVC Example
     1# Speedometer 2.0: Vanilla JavaScript TodoMVC example
    22
    3 > JavaScript® (often shortened to JS) is a lightweight, interpreted, object-oriented language with first-class functions, most known as the scripting language for Web pages, but used in many non-browser environments as well such as node.js or Apache CouchDB.
     3## Test locally
    44
    5 > _[JavaScript - developer.mozilla.org](http://developer.mozilla.org/en-US/docs/JavaScript)
     51. Run a local server from this directory. (You could use [`npm i -g http-server`](https://github.com/indexzero/http-server).)
     62. Open the URL pointing to the local server in your web browser of choice.
     7
     8## Build
     9
     10There is no build step for this example.
Note: See TracChangeset for help on using the changeset viewer.