Changeset 219295 in webkit
- Timestamp:
- Jul 10, 2017 9:23:19 AM (7 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 2 deleted
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r219293 r219295 1 2017-07-10 Michael Catanzaro <mcatanzaro@igalia.com> 2 3 [SOUP] Remove WebKitSoupCookieJarSqlite 4 https://bugs.webkit.org/show_bug.cgi?id=174310 5 6 Reviewed by Carlos Garcia Campos. 7 8 It seems WebKitSoupCookieJarSqlite uses exactly the same database format as the upstream 9 SoupCookieJarDb class. WebKitSoupCookieJarSqlite is a copy of SoupCookieJarSqlite that uses 10 WebCore's SQLite wrapper and WTF stuff. WebKitSoupCookieJarSqlite exists only because 11 SoupCookieJarDb is relatively new, and the older SoupCookieJarSqlite class existed only in 12 libsoup-gnome rather than libsoup proper. The advantage of continuing to use our 13 WebKitSoupCookieJarSqlite class, besides that we already know it works, is that it utilizes 14 the same SQLiteDatabase class that is used elsewhere in WebKit. But that's not really any 15 reason to keep the class around, when SoupCookieJarDb does exactly the same thing. It was 16 introduced in libsoup 2.42 and that is already our minimum required version, so we can 17 switch now. 18 19 This passes a quick sanity-check of Epiphany's cookies dialog and also TestCookieManager. 20 21 * PlatformGTK.cmake: 22 * PlatformWPE.cmake: 23 * WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: 24 (WebKit::WebCookieManager::setCookiePersistentStorage): 25 * WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp: Removed. 26 * WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.h: Removed. 27 1 28 2017-07-10 Myles C. Maxfield <mmaxfield@apple.com> 2 29 -
trunk/Source/WebKit2/PlatformGTK.cmake
r219049 r219295 240 240 241 241 WebProcess/Cookies/soup/WebCookieManagerSoup.cpp 242 WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp243 242 244 243 WebProcess/InjectedBundle/API/glib/WebKitConsoleMessage.cpp -
trunk/Source/WebKit2/PlatformWPE.cmake
r219049 r219295 223 223 224 224 WebProcess/Cookies/soup/WebCookieManagerSoup.cpp 225 WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp226 225 227 226 WebProcess/InjectedBundle/API/glib/WebKitConsoleMessage.cpp -
trunk/Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp
r212626 r219295 28 28 29 29 #include "ChildProcess.h" 30 #include "WebKitSoupCookieJarSqlite.h"31 30 #include <WebCore/NetworkStorageSession.h> 32 31 #include <WebCore/SoupNetworkSession.h> … … 82 81 break; 83 82 case SoupCookiePersistentStorageSQLite: 84 jar = adoptGRef( webkitSoupCookieJarSqliteNew(storagePath));83 jar = adoptGRef(soup_cookie_jar_db_new(storagePath.utf8().data(), FALSE)); 85 84 break; 86 85 default:
Note: See TracChangeset
for help on using the changeset viewer.