Changeset 219396 in webkit


Ignore:
Timestamp:
Jul 12, 2017 8:57:14 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Wrong radix used in Unicode Escape in invalid character error message
​https://bugs.webkit.org/show_bug.cgi?id=174419

Patch by Tooru Fujisawa [:arai] <​arai.unmht@gmail.com> on 2017-07-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer<T>::invalidCharacterMessage):

LayoutTests:

  • fast/loader/cache-encoding-expected.txt:
  • http/tests/preload/preload-encoding-expected.txt:
  • js/basic-strict-mode-expected.txt:
  • js/kde/parse-expected.txt:
  • loader/reload-subresource-when-type-changes-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:
Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r219393 r219396  
     12017-07-12  Tooru Fujisawa [:arai]  <arai.unmht@gmail.com>
     2
     3        Wrong radix used in Unicode Escape in invalid character error message
     4        https://bugs.webkit.org/show_bug.cgi?id=174419
     5
     6        Reviewed by Alex Christensen.
     7
     8        * fast/loader/cache-encoding-expected.txt:
     9        * http/tests/preload/preload-encoding-expected.txt:
     10        * js/basic-strict-mode-expected.txt:
     11        * js/kde/parse-expected.txt:
     12        * loader/reload-subresource-when-type-changes-expected.txt:
     13        * platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
     14        * platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:
     15
    1162017-07-12  Youenn Fablet  <youenn@apple.com>
    217

  • trunk/LayoutTests/fast/loader/cache-encoding-expected.txt

    r217300 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8307'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2073'
    22First load a script with a wrong charset then again with the right one. Second attempt should work and 'scriptSuccess' should be set to true.
    33

  • trunk/LayoutTests/http/tests/preload/preload-encoding-expected.txt

    r217289 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8307'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2073'
    22First load a script with a wrong charset then again with the right one. Second attempt should work and 'scriptSuccess' should be set to true. 'successfullyParsed' will be undefined.
    33

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r219395 r219396  
     12017-07-12  Tooru Fujisawa [:arai]  <arai.unmht@gmail.com>
     2
     3        Wrong radix used in Unicode Escape in invalid character error message
     4        https://bugs.webkit.org/show_bug.cgi?id=174419
     5
     6        Reviewed by Alex Christensen.
     7
     8        * web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt:
     9        * web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt:
     10
    1112017-07-12  Frederic Wang  <fwang@igalia.com>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt

    r206201 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
    2 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
     2CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
    33CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
    44layer at (0,0) size 800x600

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt

    r206201 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
    2 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
     2CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
    33CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
    44layer at (0,0) size 800x600

  • trunk/LayoutTests/js/basic-strict-mode-expected.txt

    r208867 r219396  
    190190PASS (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(f.__proto__, 'arguments'); return descriptor.get === descriptor.set; })() is true
    191191PASS 'use strict'; (function f() { for(var i in this); })(); true; is true
    192 PASS 'use strict'̻ threw exception SyntaxError: Invalid character '\u0827'.
    193 PASS (function(){'use strict'̻}) threw exception SyntaxError: Invalid character '\u0827'.
     192PASS 'use strict'̻ threw exception SyntaxError: Invalid character '\u033b'.
     193PASS (function(){'use strict'̻}) threw exception SyntaxError: Invalid character '\u033b'.
    194194PASS 'use strict'5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
    195195PASS (function(){'use strict'5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.
    196 PASS 'use strict';̻ threw exception SyntaxError: Invalid character '\u0827'.
    197 PASS (function(){'use strict';̻}) threw exception SyntaxError: Invalid character '\u0827'.
     196PASS 'use strict';̻ threw exception SyntaxError: Invalid character '\u033b'.
     197PASS (function(){'use strict';̻}) threw exception SyntaxError: Invalid character '\u033b'.
    198198PASS 'use strict';5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
    199199PASS (function(){'use strict';5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.

  • trunk/LayoutTests/js/kde/parse-expected.txt

    r158014 r219396  
    1717PASS function test() { while(0) continue lab } lab: 1 threw exception SyntaxError: Cannot use the undeclared label 'lab'..
    1818PASS var éĀʯΈᢨ = 101; éĀʯΈᢨ; is 101
    19 PASS var f÷; threw exception SyntaxError: Invalid character '\u0247'.
     19PASS var f÷; threw exception SyntaxError: Invalid character '\u00f7'.
    2020PASS var \u0061 = 102; a is 102
    2121PASS var f\u0030 = 103; f0 is 103

  • trunk/LayoutTests/loader/reload-subresource-when-type-changes-expected.txt

    r90265 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u8240'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2030'
    22PASS 1 of 3
    33PASS 2 of 3

  • trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-003-expected.txt

    r206201 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
    2 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
     2CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
    33CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
    44layer at (0,0) size 800x600

  • trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-004-expected.txt

    r206201 r219396  
    1 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
    2 CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u10799'
     1CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
     2CONSOLE MESSAGE: line 1: SyntaxError: Invalid character '\u2a2f'
    33CONSOLE MESSAGE: line 25: ReferenceError: Can't find variable: test
    44layer at (0,0) size 800x600

  • trunk/Source/JavaScriptCore/ChangeLog

    r219379 r219396  
     12017-07-12  Tooru Fujisawa [:arai]  <arai.unmht@gmail.com>
     2
     3        Wrong radix used in Unicode Escape in invalid character error message
     4        https://bugs.webkit.org/show_bug.cgi?id=174419
     5
     6        Reviewed by Alex Christensen.
     7
     8        * parser/Lexer.cpp:
     9        (JSC::Lexer<T>::invalidCharacterMessage):
     10
    1112017-07-11  Dean Jackson  <dino@apple.com>
    212

  • trunk/Source/JavaScriptCore/parser/Lexer.cpp

    r219285 r219396  
    526526        return ASCIILiteral("Invalid character: '`'");
    527527    default:
    528         return String::format("Invalid character '\\u%04u'", static_cast<unsigned>(m_current));
     528        return String::format("Invalid character '\\u%04x'", static_cast<unsigned>(m_current));
    529529    }
    530530}
Note: See TracChangeset for help on using the changeset viewer.