Changeset 219604 in webkit

Timestamp:

Jul 17, 2017 11:28:58 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Web Automation: link and partial link queries don't work if text link contains trailing or leading whitespaces
​https://bugs.webkit.org/show_bug.cgi?id=174499

Reviewed by Brian Burg.

This is causing test test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace to fail.

• UIProcess/Automation/atoms/FindNodes.js:

(switch): Use normalize-space() in in the links xpath expressions.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/atoms/FindNodes.js (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-07-17  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Web Automation: link and partial link queries don't work if text link contains trailing or leading whitespaces
+        https://bugs.webkit.org/show_bug.cgi?id=174499
+
+        Reviewed by Brian Burg.
+
+        This is causing test test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace to fail.
+
+        * UIProcess/Automation/atoms/FindNodes.js:
+        (switch): Use normalize-space() in in the links xpath expressions.
+
 2017-07-17  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js

@@ -38 +38 @@
     case "link text":
         strategy = "xpath";
-        query = ".//a[@href][descendant-or-self::text() = \"" + escape(query) + "\"]";
+        query = ".//a[@href][normalize-space(descendant-or-self::text()) = \"" + escape(query) + "\"]";
         break;
     case "partial link text":
         strategy = "xpath";
-        query = ".//a[@href][contains(descendant-or-self::text(), \"" + escape(query) + "\")]";
+        query = ".//a[@href][contains(normalize-space(descendant-or-self::text()), \"" + escape(query) + "\")]";
         break;
     }