Changeset 219640 in webkit

Timestamp:

Jul 18, 2017 4:22:46 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Add performance.mark()s around each test step
​https://bugs.webkit.org/show_bug.cgi?id=174530

Patch by Matt Kotsenas <​mattkot@microsoft.com> on 2017-07-18
Reviewed by Ryosuke Niwa.

Add performance.mark() around each test step to make analysis
simpler. Now each test step can be investigated via dev tools, ETW, etc.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._writeMark):
(BenchmarkRunner.prototype._runTest):
(BenchmarkRunner.prototype._runTestAndRecordResults):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Speedometer/resources/benchmark-runner.js (modified) (3 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-07-18  Matt Kotsenas  <mattkot@microsoft.com>
+
+        Add performance.mark()s around each test step
+        https://bugs.webkit.org/show_bug.cgi?id=174530
+
+        Reviewed by Ryosuke Niwa.
+
+        Add `performance.mark()` around each test step to make analysis
+        simpler. Now each test step can be investigated via dev tools, ETW, etc.
+
+        * Speedometer/resources/benchmark-runner.js:
+        (BenchmarkRunner.prototype._writeMark):
+        (BenchmarkRunner.prototype._runTest):
+        (BenchmarkRunner.prototype._runTestAndRecordResults):
+
 2017-07-14  Saam Barati  <sbarati@apple.com>
 

trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js

@@ -113 +113 @@
 }
 
+BenchmarkRunner.prototype._writeMark = function(name) {
+    if (window.performance && window.performance.mark)
+        window.performance.mark(name);
+}
+
 // This function ought be as simple as possible. Don't even use SimplePromise.
-BenchmarkRunner.prototype._runTest = function(suite, testFunction, prepareReturnValue, callback)
+BenchmarkRunner.prototype._runTest = function(suite, test, prepareReturnValue, callback)
 {
+    var self = this;
     var now = window.performance && window.performance.now ? function () { return window.performance.now(); } : Date.now;
 
-    var contentWindow = this._frame.contentWindow;
-    var contentDocument = this._frame.contentDocument;
-
+    var contentWindow = self._frame.contentWindow;
+    var contentDocument = self._frame.contentDocument;
+
+    self._writeMark(`${suite.name}.${test.name}-start`);
     var startTime = now();
-    testFunction(prepareReturnValue, contentWindow, contentDocument);
+    test.run(prepareReturnValue, contentWindow, contentDocument);
     var endTime = now();
+    self._writeMark(`${suite.name}.${test.name}-sync-end`);
+
     var syncTime = endTime - startTime;
 
@@ -129 +138 @@
     setTimeout(function () {
         var endTime = now();
+        self._writeMark(`${suite.name}.${test.name}-async-end`);
         callback(syncTime, endTime - startTime);
     }, 0);
@@ -241 +251 @@
     var self = this;
     setTimeout(function () {
-        self._runTest(suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) {
+        self._runTest(suite, test, self._prepareReturnValue, function (syncTime, asyncTime) {
             var suiteResults = self._measuredValues.tests[suite.name] || {tests:{}, total: 0};
             var total = syncTime + asyncTime;