Changeset 220126 in webkit

Timestamp:

Aug 2, 2017 1:45:15 AM (7 years ago)

Author:

Michael Catanzaro

Message:

[CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=175019

Reviewed by Darin Adler.

• TestWebKitAPI/CMakeLists.txt:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/CMakeLists.txt (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
+        https://bugs.webkit.org/show_bug.cgi?id=175019
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/CMakeLists.txt:
+
 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Tools/TestWebKitAPI/CMakeLists.txt

@@ -184 +184 @@
 )
 
-# FIXME: EFL is the only port that separates the WebCore binaries. Each port ought to do closer to the same thing.
-foreach (testName ${test_webcore_BINARIES})
-    add_executable(${testName} ${test_main_SOURCES} ${TESTWEBKITAPI_DIR}/TestsController.cpp ${TESTWEBKITAPI_DIR}/Tests/WebCore/${testName}.cpp)
-    add_test(${testName} ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebCore/${testName})
-    set_tests_properties(${testName} PROPERTIES TIMEOUT 60)
-    target_link_libraries(${testName} ${test_webcore_LIBRARIES})
-    set_target_properties(${testName} PROPERTIES
-        RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebCore
-    )
-endforeach ()
-
 if (ENABLE_WEBKIT)
     add_library(TestWebKitAPIBase
@@ -207 +196 @@
 
     add_dependencies(TestWebKitAPIBase WebKit2 ${ForwardingHeadersForTestWebKitAPI_NAME} ${ForwardingNetworkHeadersForTestWebKitAPI_NAME})
-
-    foreach (testName ${test_webkit2_api_BINARIES})
-        get_filename_component(testBaseName ${testName} NAME)
-        add_executable(${testBaseName} ${TESTWEBKITAPI_DIR}/Tests/WebKit/${testName}.cpp)
-        add_test(${testBaseName} ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit/${testBaseName})
-        set_tests_properties(${testBaseName} PROPERTIES TIMEOUT 60)
-        target_link_libraries(${testBaseName} ${test_webkit2_api_LIBRARIES})
-        set_target_properties(${testBaseName} PROPERTIES
-            RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit
-        )
-    endforeach ()
-
-    # We don't run tests that are expected to fail. We could use the WILL_FAIL
-    # property, but it reports failure when the test crashes or timeouts and would
-    # make the bot red.
-    foreach (testName ${test_webkit2_api_fail_BINARIES})
-        add_executable(${testName} ${TESTWEBKITAPI_DIR}/Tests/WebKit/${testName}.cpp)
-        target_link_libraries(${testName} ${test_webkit2_api_LIBRARIES})
-        set_target_properties(${testName} PROPERTIES
-            RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebKit/failure
-        )
-    endforeach ()
 endif ()