Changeset 220245 in webkit


Ignore:
Timestamp:
Aug 3, 2017 6:07:24 PM (7 years ago)
Author:
Chris Dumez
Message:

Multiple Layout tests from web-platform-tests/beacon/ are timing out.
​https://bugs.webkit.org/show_bug.cgi?id=175076
<rdar://problem/33704752>

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Rebaseline tests that are now passing.

  • web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt:

Source/WebKit:

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::completeAuthenticationChallenge):
In the NETWORK_SESSION code path, we did not ask the client about server trust evaluation
when the clientCredentialPolicy was CannotAskClientForCredentials. This is because the
same delegate is used for HTTP authentication and server trust evaluation in the
NETWORK_SESSION code path. To align both code paths, we now ask the client about server
trust evaluation even if the policy CannotAskClientForCredentials. This allows WKTR
to trust certificates for localhost / 127.0.0.1 unconditionally and consistently.

LayoutTests:

  • platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.

Drop platform-specific expectations as those tests are now passing everywhere.

  • platform/wk2/TestExpectations:

Unskip tests that are now passing.

Location:
trunk
Files:
7 deleted
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r220233 r220245  
     12017-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Multiple Layout tests from web-platform-tests/beacon/ are timing out.
     4        https://bugs.webkit.org/show_bug.cgi?id=175076
     5        <rdar://problem/33704752>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
     10        * platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.
     11        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Removed.
     12        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Removed.
     13        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Removed.
     14        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Removed.
     15        * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Removed.
     16        * platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
     17        * platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.
     18        Drop platform-specific expectations as those tests are now passing everywhere.
     19
     20        * platform/wk2/TestExpectations:
     21        Unskip tests that are now passing.
     22
    1232017-08-03  Matt Baker  <mattbaker@apple.com>
    224

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r220244 r220245  
     12017-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Multiple Layout tests from web-platform-tests/beacon/ are timing out.
     4        https://bugs.webkit.org/show_bug.cgi?id=175076
     5        <rdar://problem/33704752>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        Rebaseline tests that are now passing.
     10
     11        * web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt:
     12        * web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt:
     13        * web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt:
     14        * web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt:
     15        * web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt:
     16
    1172017-08-03  Youenn Fablet  <youenn@apple.com>
    218

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt

    r215515 r220245  
    11CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    22CONSOLE MESSAGE: Fetch API cannot load http://localhost:8801/fetch/api/resources/top.txt. Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     3CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     4CONSOLE MESSAGE: Fetch API cannot load https://localhost:9443/fetch/api/resources/top.txt. Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    35CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    46CONSOLE MESSAGE: Fetch API cannot load http://127.0.0.1:8800/fetch/api/resources/top.txt. Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    57CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    68CONSOLE MESSAGE: Fetch API cannot load http://127.0.0.1:8801/fetch/api/resources/top.txt. Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     9CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     10CONSOLE MESSAGE: Fetch API cannot load https://127.0.0.1:9443/fetch/api/resources/top.txt. Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    711
    812PASS Same domain different port [no-cors mode]
    913PASS Same domain different port [server forbid CORS]
    1014PASS Same domain different port [cors mode]
    11 FAIL Same domain different protocol different port [no-cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     15PASS Same domain different protocol different port [no-cors mode]
    1216PASS Same domain different protocol different port [server forbid CORS]
    13 FAIL Same domain different protocol different port [cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     17PASS Same domain different protocol different port [cors mode]
    1418PASS Cross domain basic usage [no-cors mode]
    1519PASS Cross domain basic usage [server forbid CORS]
    … …  
    1822PASS Cross domain different port [server forbid CORS]
    1923PASS Cross domain different port [cors mode]
    20 FAIL Cross domain different protocol [no-cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     24PASS Cross domain different protocol [no-cors mode]
    2125PASS Cross domain different protocol [server forbid CORS]
    22 FAIL Cross domain different protocol [cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     26PASS Cross domain different protocol [cors mode]
    2327

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt

    r215515 r220245  
     1CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     2CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    13CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    24CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    … …  
    68PASS Same domain different port [server forbid CORS]
    79PASS Same domain different port [cors mode]
    8 FAIL Same domain different protocol different port [no-cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     10PASS Same domain different protocol different port [no-cors mode]
    911PASS Same domain different protocol different port [server forbid CORS]
    10 FAIL Same domain different protocol different port [cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     12PASS Same domain different protocol different port [cors mode]
    1113PASS Cross domain basic usage [no-cors mode]
    1214PASS Cross domain basic usage [server forbid CORS]
    … …  
    1517PASS Cross domain different port [server forbid CORS]
    1618PASS Cross domain different port [cors mode]
    17 FAIL Cross domain different protocol [no-cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     19PASS Cross domain different protocol [no-cors mode]
    1820PASS Cross domain different protocol [server forbid CORS]
    19 FAIL Cross domain different protocol [cors mode] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     21PASS Cross domain different protocol [cors mode]
    2022

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt

    r215515 r220245  
    33PASS Same domain different port [GET]
    44PASS Cross domain different port [GET]
    5 FAIL Cross domain different protocol [GET] promise_test: Unhandled rejection with value: object "TypeError: Type error"
    6 FAIL Same domain different protocol different port [GET] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     5PASS Cross domain different protocol [GET]
     6PASS Same domain different protocol different port [GET]
    77PASS Cross domain [POST]
    88PASS Cross domain [HEAD]

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt

    r215515 r220245  
    33PASS Same domain different port [GET]
    44PASS Cross domain different port [GET]
    5 FAIL Cross domain different protocol [GET] promise_test: Unhandled rejection with value: object "TypeError: Type error"
    6 FAIL Same domain different protocol different port [GET] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     5PASS Cross domain different protocol [GET]
     6PASS Same domain different protocol different port [GET]
    77PASS Cross domain [POST]
    88PASS Cross domain [HEAD]

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt

    r215515 r220245  
    66PASS Cross domain different port [origin OK]
    77PASS Cross domain different port [origin KO]
    8 FAIL Cross domain different protocol [origin OK] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     8PASS Cross domain different protocol [origin OK]
    99PASS Cross domain different protocol [origin KO]
    10 FAIL Same domain different protocol different port [origin OK] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     10PASS Same domain different protocol different port [origin OK]
    1111PASS Same domain different protocol different port [origin KO]
    1212PASS Cross domain [POST] [origin OK]

  • trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt

    r215515 r220245  
     1CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
     2CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    13CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    24CONSOLE MESSAGE: Origin http://localhost:8800 is not allowed by Access-Control-Allow-Origin.
    … …  
    1214PASS Cross domain different port [origin OK]
    1315PASS Cross domain different port [origin KO]
    14 FAIL Cross domain different protocol [origin OK] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     16PASS Cross domain different protocol [origin OK]
    1517PASS Cross domain different protocol [origin KO]
    16 FAIL Same domain different protocol different port [origin OK] promise_test: Unhandled rejection with value: object "TypeError: Type error"
     18PASS Same domain different protocol different port [origin OK]
    1719PASS Same domain different protocol different port [origin KO]
    1820PASS Cross domain [POST] [origin OK]

  • trunk/LayoutTests/platform/wk2/TestExpectations

    r220149 r220245  
    213213http/tests/download/inherited-encoding-form-submission-result.html
    214214http/tests/download/inherited-encoding.html
    215 
    216 # Those tests are loaded over HTTPS and pass locally. However, they get an SSL error on the bots and time out.
    217 webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-no-referrer-when-downgrade.https.html [ Skip ]
    218 webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-strict-origin-when-cross-origin.https.html [ Skip ]
    219 webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-strict-origin.https.html [ Skip ]
    220 webkit.org/b/175076 imported/w3c/web-platform-tests/beacon/headers/header-referrer-unsafe-url.https.html [ Skip ]
    221215
    222216### END OF (1) Classified failures with bug reports

  • trunk/Source/WebKit/ChangeLog

    r220243 r220245  
     12017-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Multiple Layout tests from web-platform-tests/beacon/ are timing out.
     4        https://bugs.webkit.org/show_bug.cgi?id=175076
     5        <rdar://problem/33704752>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * NetworkProcess/NetworkLoad.cpp:
     10        (WebKit::NetworkLoad::completeAuthenticationChallenge):
     11        In the NETWORK_SESSION code path, we did not ask the client about server trust evaluation
     12        when the clientCredentialPolicy was CannotAskClientForCredentials. This is because the
     13        same delegate is used for HTTP authentication and server trust evaluation in the
     14        NETWORK_SESSION code path. To align both code paths, we now ask the client about server
     15        trust evaluation even if the policy CannotAskClientForCredentials. This allows WKTR
     16        to trust certificates for localhost / 127.0.0.1 unconditionally and consistently.
     17
    1182017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
    219

  • trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp

    r218763 r220245  
    338338void NetworkLoad::completeAuthenticationChallenge(ChallengeCompletionHandler&& completionHandler)
    339339{
    340     if (m_parameters.clientCredentialPolicy == ClientCredentialPolicy::CannotAskClientForCredentials) {
     340    bool isServerTrustEvaluation = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested;
     341    if (m_parameters.clientCredentialPolicy == ClientCredentialPolicy::CannotAskClientForCredentials && !isServerTrustEvaluation) {
    341342        completionHandler(AuthenticationChallengeDisposition::UseCredential, { });
    342343        return;
Note: See TracChangeset for help on using the changeset viewer.