Changeset 220287 in webkit


Ignore:
Timestamp:
Aug 4, 2017 1:01:16 PM (7 years ago)
Author:
aakash_jain@apple.com
Message:

Dashboard bubbles sometimes show failure count instead of crash count
https://bugs.webkit.org/show_bug.cgi?id=175157
<rdar://problem/33709009>

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js

    r220120 r220287  
    7676        function resultSummarizer(matchString, sum, outputLine)
    7777        {
    78             var match = /^(\d+)\s/.exec(outputLine);
     78            // Sample outputLine: "53 failures 37 new passes 1 crashes"
     79            var regex = new RegExp("(\\d+)\\s" + matchString);
     80            match = regex.exec(outputLine);
    7981            if (!match) {
    80                 var regex = new RegExp("(\\d+)\\s" + matchString);
    81                 match = regex.exec(outputLine);
     82                match = /^(\d+)\s/.exec(outputLine);
    8283            }
    8384            if (!match)
  • trunk/Tools/ChangeLog

    r220284 r220287  
     12017-08-04  Aakash Jain  <aakash_jain@apple.com>
     2
     3        Dashboard bubbles sometimes show failure count instead of crash count
     4        https://bugs.webkit.org/show_bug.cgi?id=175157
     5        <rdar://problem/33709009>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
     10        (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
     11
    1122017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
    213
Note: See TracChangeset for help on using the changeset viewer.