Changeset 220454 in webkit

Timestamp:

Aug 9, 2017 6:06:11 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
​https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/PlatformMediaSessionManager.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-09  Ms2ger  <Ms2ger@igalia.com>
+
+        Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
+        https://bugs.webkit.org/show_bug.cgi?id=175375
+
+        Reviewed by Sam Weinig.
+
+        Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.
+
+        These should have been removed in r207688.
+
+        No new tests: no behavior change.
+
+        * platform/audio/PlatformMediaSessionManager.cpp:
+        (WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
+        (WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
+        (WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
+        (WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):
+
 2017-08-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp

@@ -299 +299 @@
     LOG(Media, "PlatformMediaSessionManager::applicationWillBecomeInactive");
 
-    Vector<PlatformMediaSession*> sessions = m_sessions;
     forEachSession([&] (PlatformMediaSession& session, size_t) {
         if (m_restrictions[session.mediaType()] & InactiveProcessPlaybackRestricted)
@@ -310 +309 @@
     LOG(Media, "PlatformMediaSessionManager::applicationDidBecomeActive");
 
-    Vector<PlatformMediaSession*> sessions = m_sessions;
     forEachSession([&] (PlatformMediaSession& session, size_t) {
         if (m_restrictions[session.mediaType()] & InactiveProcessPlaybackRestricted)
@@ -325 +323 @@
 
     m_isApplicationInBackground = true;
-    
-    Vector<PlatformMediaSession*> sessions = m_sessions;
+
     forEachSession([&] (PlatformMediaSession& session, size_t) {
         if (suspendedUnderLock && m_restrictions[session.mediaType()] & SuspendedUnderLockPlaybackRestricted)
@@ -344 +341 @@
     m_isApplicationInBackground = false;
 
-    Vector<PlatformMediaSession*> sessions = m_sessions;
     forEachSession([&] (PlatformMediaSession& session, size_t) {
         if ((suspendedUnderLock && m_restrictions[session.mediaType()] & SuspendedUnderLockPlaybackRestricted) || m_restrictions[session.mediaType()] & BackgroundProcessPlaybackRestricted)