Changeset 220535 in webkit

Timestamp:

Aug 10, 2017 11:27:01 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r220463.
​https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
​https://bugs.webkit.org/show_bug.cgi?id=175340
​http://trac.webkit.org/changeset/220463

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/add-children-pseudo-element-expected.txt (deleted)
• LayoutTests/accessibility/add-children-pseudo-element.html (deleted)
• LayoutTests/accessibility/resources/svg-circle.svg (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlockFlow.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r220463.
+        https://bugs.webkit.org/show_bug.cgi?id=175435
+
+        unaccepted fix (Requested by n_wang on #webkit).
+
+        Reverted changeset:
+
+        "AX: crash at
+        WebCore::AccessibilityObject::supportsARIALiveRegion() const +
+        24"
+        https://bugs.webkit.org/show_bug.cgi?id=175340
+        http://trac.webkit.org/changeset/220463
+
 2017-08-10  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r220463.
+        https://bugs.webkit.org/show_bug.cgi?id=175435
+
+        unaccepted fix (Requested by n_wang on #webkit).
+
+        Reverted changeset:
+
+        "AX: crash at
+        WebCore::AccessibilityObject::supportsARIALiveRegion() const +
+        24"
+        https://bugs.webkit.org/show_bug.cgi?id=175340
+        http://trac.webkit.org/changeset/220463
+
 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -25 +25 @@
 #include "RenderBlockFlow.h"
 
-#include "AXObjectCache.h"
 #include "Editor.h"
 #include "FloatingObjects.h"
@@ -2354 +2353 @@
 
     setLogicalWidthForFloat(*floatingObject, logicalWidthForChild(floatBox) + marginStartForChild(floatBox) + marginEndForChild(floatBox));
-    
-    if (AXObjectCache* cache = document().existingAXObjectCache())
-        cache->childrenChanged(this);
 
     return m_floatingObjects->add(WTFMove(floatingObject));
@@ -2394 +2390 @@
             }
             m_floatingObjects->remove(&floatingObject);
-            
-            if (AXObjectCache* cache = document().existingAXObjectCache())
-                cache->childrenChanged(this);
         }
     }