Changeset 220581 in webkit

Timestamp:

Aug 10, 2017 11:02:33 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[Soup] Do not spawn the network process to setup cookie persistent storage
​https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

• UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/soup/WebCookieManagerProxySoup.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Soup] Do not spawn the network process to setup cookie persistent storage
+        https://bugs.webkit.org/show_bug.cgi?id=175424
+
+        Reviewed by Sergio Villar Senin.
+
+        The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
+        need to spawn the network process to configure it, when it's created eventually it will use the configuration.
+
+        * UIProcess/soup/WebCookieManagerProxySoup.cpp:
+        (WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
+        endToNetworkingProcessRelaunchingIfNecessary().
+
 2017-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/soup/WebCookieManagerProxySoup.cpp

@@ -34 +34 @@
 void WebCookieManagerProxy::setCookiePersistentStorage(const String& storagePath, uint32_t storageType)
 {
-    processPool()->sendToNetworkingProcessRelaunchingIfNecessary(Messages::WebCookieManager::SetCookiePersistentStorage(storagePath, storageType));
-
     m_cookiePersistentStoragePath = storagePath;
     m_cookiePersistentStorageType = static_cast<SoupCookiePersistentStorageType>(storageType);
+    processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetCookiePersistentStorage(storagePath, storageType));
 }