Changeset 220638 in webkit

Timestamp:

Aug 13, 2017 11:23:27 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] stop kinetic scrolling when a zero movement is reached
​https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
​https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

• platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollAnimationKinetic.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-13  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] stop kinetic scrolling when a zero movement is reached
+        https://bugs.webkit.org/show_bug.cgi?id=175468
+
+        Reviewed by Michael Catanzaro.
+
+        This is GTK+ change by Christian Hergert.
+        https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6
+
+        When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
+        followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
+        feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.
+
+        * platform/ScrollAnimationKinetic.cpp:
+        (WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):
+
 2017-08-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/ScrollAnimationKinetic.cpp

@@ -82 +82 @@
 bool ScrollAnimationKinetic::PerAxisData::animateScroll(Seconds timeDelta)
 {
+    auto lastPosition = m_position;
+    auto lastTime = m_elapsedTime;
     m_elapsedTime += timeDelta;
 
@@ -94 +96 @@
         m_position = m_upper;
         m_velocity = 0;
-    } else if (fabs(m_velocity) < 1) {
+    } else if (fabs(m_velocity) < 1 || (lastTime && fabs(m_position - lastPosition) < 1)) {
         m_position = round(m_position);
         m_velocity = 0;